[PATCH] sit: Add 6RD support

Thomas Haller thaller at redhat.com
Fri Apr 15 06:39:20 PDT 2016


On Mon, 2016-02-08 at 08:05 -0200, Thadeu Lima de Souza Cascardo wrote:
> Handle 6RD prefixes from sit linkinfo.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
> ---

Hi Thadeu,


I finally got around to review your patch and add public API for the
functionality you add.

Could you please have a look at "sit-ip6rd" branch [1]

[1] https://github.com/thom311/libnl/commits/sit-ip6rd

The first commit is your patch. Then a few internal cleanup patches,
and lastly adding the public API. I'm mostly interested, whether the
API makes sense: the naming of the functions and their  arguments, the
code-comments, and the type of the arguments -- like uint16_t for
prefixlen?


Thanks,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20160415/997e70a5/attachment.sig>


More information about the libnl mailing list