[PATCH] Print route tables as an integer versus hex

[Thomas Haller]

On Tue, 2016-04-12 at 14:00 -0700, David Ahern wrote:

Hi David,


diff --git a/libnl-3.sym b/libnl-3.sym
> index 4e09bdd672a1..35df7206bcb4 100644
> --- a/libnl-3.sym
> +++ b/libnl-3.sym
> @@ -350,4 +350,5 @@ libnl_3_2_27 {
>  libnl_3_2_28 {
>  global:
>  	nl_object_diff64;
> +	__list_table2str;
>  } libnl_3_2_27;


I know, __list_table2str is internal API and the name follows the
pattern of existing function names.

But as this is exported ABI, the name matters. Could we please rename
it to have a "_nl" prefix? That differs from the existing naming
pattern, but I think all functions (API or ABI) should have a proper
"nl" prefix.


While I'm bike shedding, could we rename the function some more?
Basically, it's list_type2str which does hex conversion. It could be
used for different cases then "rtnl_route_table2str", so the name
should be more generic and indicate what the function does.

How about one of:
  "_nl_list_type2str_hex"
  "_nl_list_type2hexstr"
  "_nl_list_type2xstr"

best,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20160413/1d157486/attachment.sig>