[PATCH] msg: Remove unnecessary call of nlmsg_free on known NULL pointer

Thomas Haller thaller at redhat.com
Mon Jun 9 03:19:37 PDT 2014


On Mon, 2014-06-02 at 14:41 +0200, Tobias Klauser wrote:
> On 2014-06-02 at 14:14:08 +0200, Thomas Graf <tgraf at suug.ch> wrote:
> > On 05/30/14 at 04:10pm, Tobias Klauser wrote:
> > > In nlmsg_convert, if __nlmsg_alloc fails we can return NULL directly
> > > instead of unnecessarilyunnecessarily  calling nlmsg_free on the NULL pointer.
> >                  ^^^^^^^^^^^^^^^^
> > @Thomas: Can you fix the above while commiting?
> 
> Oops, sorry about that. I can also resend the patch with the proper
> message if you want.
> 
> Cheers


ah, it's fine, I fixed it :)

Applied as
https://github.com/thom311/libnl/commit/872544c0c0283db1e048969d17982398aca6934b


Thank you!!
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20140609/ec3bb8ec/attachment.sig>


More information about the libnl mailing list