[PATCH 1/2] utils: Define ARRAY_SIZE() if not yet defined

Thomas Graf tgraf at suug.ch
Wed Aug 27 04:59:04 PDT 2014


On 08/27/14 at 01:48pm, Thomas Haller wrote:
> isn't it problematic to define ARRAY_SIZE in our public headers?
> 
> I feel we should not define anything without our nl specific prefixes.
> 
> 
> maybe we can add another project-internal (private) header, that can be
> used by ./src/ too?

The issue here is that this should really be part of libc.

I thought about the the prefix and I'm fine with that. ARRAY_SIZE()
seems pretty well defined which is why I've added the #ifndef.
ARRAY_SIZE() was already part of the private header but src/ is
supposed to be using the public headers. I would rather add it to
pktloc itself than start using private headers widely in src/





More information about the libnl mailing list