bug in nl_cache_mngr_data_ready / nl_cache_refill / nl_cache_resync [+patch proposition]

Thomas Graf tgraf at infradead.org
Tue Apr 24 03:09:24 EDT 2012


On Mon, Apr 23, 2012 at 10:42:58AM -0400, Brett Ciphery wrote:
> I was looking at comments of nl_recvmsgs() which
> nl_cache_mngr_data_ready() calls:
> 
>  * Repeatedly calls nl_recv() or the respective replacement if provided
>  * by the application (see nl_cb_overwrite_recv()) and parses the
>  * received data as netlink messages. Stops reading if one of the
>  * callbacks returns NL_STOP or nl_recv returns either 0 or a negative
>  * error code.
> 
> and so thought the expected behaviour would be to loop until there was
> nothing left.  Returning a count is clean though, I'll check how this
> works with nl_cache_mngr_data_ready() and other cache refilling
> functions.

I will reword that comment, it's misleading. Thanks Brett.



More information about the libnl mailing list