<html><body>
<p> </p>
<blockquote>
<div class="message_header"><span>Wed Apr 04 2012 06:52:39 EDT</span><span>from "Robie Basak" <robie.basak@canonical.com> </span><span class="message_subject">Subject: Re: [Freeassociation-devel] [PATCH] Memory corruption in timezone handling</span></div>
<div class="message_content"><tt>On Tue, Apr 03, 2012 at 10:44:08AM -0400, Wilfried Goesgens wrote:</tt><br /><br /><br /><tt>In the meantime, would you be willing to take this patch as a temporary</tt><br /><tt>workaround, given that it's causing memory corruption in its current</tt><br /><tt>state?</tt><br /><br /><tt>Since the problem is with the builtin_timezones array growing (and thus</tt><br /><tt>moving), if I set the initial size of the array large enough, the</tt><br /><tt>problem goes away. On my system, this stops evolution from crashing on</tt><br /><tt>calendar startup. I imagine sizeof(icaltimezone) to be quite small, so I</tt><br /><tt>don't think this will waste too much memory.</tt><br /><br /><br /><tt>Index: libical-0.48/src/libical/icaltimezone.c</tt><br /><tt>===================================================================</tt><br /><tt>--- libical-0.48orig/src/libical/icaltimezone.c 2011-12-13 17:08:18.000000000 +0000</tt><br /><tt>+++ libical-0.48/src/libical/icaltimezone.c 2012-04-01 12:15:00836064296 +0000</tt><br /><tt>@@ -1656,7 +1656,7 @@</tt><br /><tt>icalerror_assert (builtin_timezones == NULL,</tt><br /><tt>"Parsing zones.tab file multiple times");</tt><br /><br /><tt>- builtin_timezones = icalarray_new (sizeof (icaltimezone), 32);</tt><br /><tt>+ builtin_timezones = icalarray_new (sizeof (icaltimezone), 1024);</tt></div>
<div class="message_content"> </div>
</blockquote>
<div class="message_content">hm, yes, probably a good idea. its 5 pointers, an int and two doubles.</div>
<div class="message_content">maybe letting configure define that value would be an even better idea.</div>
<div class="message_content"> </div>
<div class="message_content">Wilfried Goesgens</div>
</body></html>