<html><body>
<p>Allen,</p>
<p>Since that code clearly introduced bugs internaly I'd be willing to increase the library version if thats needed to indicate a client needs a recompile.</p>
<p>could you name a place where unsigned char* is depended on?</p>
<blockquote>
<div class="message_header"><span>Sa Mär 06 2010 00:24:45 CET</span> <span>von "Allen Winter" <winter@kde.org> </span> <span class="message_subject">Betreff: Re: [Freeassociation-devel] Commit R981 / R903</span></div>
<div class="message_content"><tt>On Tuesday 22 December 2009 7:34:29 am dothebart wrote:</tt><br />
<blockquote><tt>libical/src/libical/ (icalattach.c icalattach.h): </tt><br /> <tt>13:25 CIA-14: libical: * unsigned char* why?</tt><br /> <tt>13:25 CIA-14: libical: * remove const casts; this is a place where casting away const definitely gave us a bug, as fixed by Allen earlier.</tt><br /> <tt>Allen, since you've fixed a crash in R903 and the experiences we've collected with libicals code so far...</tt><br /> <tt>Its probably always a good idea to question the surrounding code and have a look the place where they're called.</tt><br /> <tt>The caller of icalattach_new_from_data() casted away a const char* which most probably was the reason for this crash?</tt><br /> <tt>so, having a look at the bigger picture around a bug often shows more places for code cleanup, or even possible removal for now abandoned code;</tt><br /> <tt>maybe somewhen in the future libical will have clean code ;-)</tt><br /> <tt></tt><br /></blockquote>
<tt>Unfortunately, doing this changes the source and binary compatibility</tt><br /> <tt>Assuming our next release is 0.45 (i.e. a point release), I don't think </tt><br /> <tt>this is a good idea.</tt><br /> <tt></tt><br /> <tt>If this was C++ we could add a new overload; since it's C we need another idea.</tt><br /> <tt></tt><br /> <tt>I suggest putting back the old icalattach_new_from_data() and make a new</tt><br /> <tt>function called icalattach_new_from_udata(). Put a big comment in the header</tt><br /> <tt>that icalattach_new_from_data() is deprecated and to please use</tt><br /> <tt>icalattach_new_from_udata() instead.</tt><br /> <tt></tt><br /> <tt>or some-such.</tt><br /> <tt></tt><br /> <tt>comments on this?</tt><br /> <tt></tt><br /> <tt>------------------------------------------------------------------------------</tt><br /> <tt>Download Intel® Parallel Studio Eval</tt><br /> <tt>Try the new software tools for yourself. Speed compiling, find bugs</tt><br /> <tt>proactively, and fine-tune applications for parallel performance.</tt><br /> <tt>See why Intel Parallel Studio got high marks during beta.</tt><br /> <tt><a href="http://p.sf.net/sfu/intel-sw-dev" target="webcit01">http://p.sf.net/sfu/intel-sw-dev</a></tt><br /> <tt>_______________________________________________</tt><br /> <tt>Freeassociation-devel mailing list</tt><br /> <tt>Freeassociation-devel@lists.sourceforge.net</tt><br /> <tt>https://lists.sourceforge.net/lists/listinfo/freeassociation-devel</tt><br /> <br /></div>
</blockquote>
<p> </p>
</body></html>