<html><body>
<p>Hy Gren,</p>
<p>Could you split your patch between style guide patches and functional patches please?</p>
<p>Which flags do you use? does --pedantic give these warnings?</p>
<p>Do you have bug references to the functional patches you did like a bugzilla link?</p>
<blockquote>
<div class="message_header"><span>Mi Aug 05 2009 08:43:13 EDT</span> <span>von "Gren Elliot" <gren.elliot@scalix.com> </span> <span class="message_subject">Betreff: [Freeassociation-devel] libical fixes for review (and commit if ok please)</span></div>
<div class="message_content"><tt>Hi Libical maintainers,</tt><br /> <tt></tt><br /> <tt>We (Scalix) have a few fixes which we hope will make the shiny new </tt><br /> <tt>release you appear to be planning. I do not have commit access to SVN. </tt><br /> <tt>So, if the fixes look good to you, please could someone commit them. </tt><br /> <tt>Alternatively, how do I go about becoming a developer with commit access </tt><br /> <tt>(and what is the associated protocol for making fixes).</tt><br /> <tt></tt><br /> <tt>The first bug is that "icalproperty_recurrence_is_excluded" ignores </tt><br /> <tt>timezone associated with an EXDATE</tt><br /> <tt>The new code uses "icalcomponent_get_datetime" instead of </tt><br /> <tt>"icalproperty_get_exdate" so that the related timezone can be found.</tt><br /> <tt></tt><br /> <tt>Whilst in icalcomponent.c, I replaced "()" with "(void)" for some </tt><br /> <tt>functions and function prototypes to avoid loads of "warning: function </tt><br /> <tt>declaration isn’t a prototype" errors which we have enabled for our </tt><br /> <tt>product builds. There is a precedent for this style already in the </tt><br /> <tt>libical code. (I have a few more of the same change for other source </tt><br /> <tt>files/headers I would like to make too).</tt><br /> <tt></tt><br /> <tt>Finally, a fix for the bug that DTSTART values are incorrect in </tt><br /> <tt>VTIMEZONE components derived automatically from Olsen tzdata information</tt><br /> <tt>e.g. for Europe/Zurich "icaltzutil_fetch_timezone"</tt><br /> <tt>yields STANDARD DTSTART = 19701025T020000</tt><br /> <tt>and DAYLIGHT DTSTART = 19700328T030000</tt><br /> <tt>However, the source file zoneinfo/Europe/Zurich.ics in SVN</tt><br /> <tt>yields STANDARD DTSTART = 19701025T030000</tt><br /> <tt>and DAYLIGHT DTSTART = 19700329T020000</tt><br /> <tt></tt><br /> <tt>I found <a href="http://tools.ietf.org/html/draft-ietf-calsify-rfc2445bis-10" target="webcit01">http://tools.ietf.org/html/draft-ietf-calsify-rfc2445bis-10</a> a </tt><br /> <tt>bit confusing, so I queried the difference in the ietf-calsify list and </tt><br /> <tt>was pointed to the following by Bernard Desruisseaux :</tt><br /> <tt></tt><br /> <tt>See Section 3.6.5. Time Zone Component:</tt><br /> <tt></tt><br />
<blockquote><tt>The mandatory "DTSTART" property gives the effective onset date</tt><br /> <tt>and local time for the time zone sub-component definition.</tt><br /> <tt>"DTSTART" in this usage MUST be specified as a date with local</tt><br /> <tt>time value.</tt><br /> <tt></tt><br /> <tt>The mandatory "TZOFFSETFROM" property gives the UTC offset which</tt><br /> <tt>is in use when the onset of this time zone observance begins.</tt><br /> <tt>"TZOFFSETFROM" is combined with "DTSTART" to define the effective</tt><br /> <tt>onset for the time zone sub-component definition. For example,</tt><br /> <tt>the following represents the time at which the observance of</tt><br /> <tt>Standard Time took effect in Fall 1967 for New York City:</tt><br /> <tt></tt><br /> <tt>DTSTART:19671029T020000</tt><br /> <tt></tt><br /> <tt>TZOFFSETFROM:-0400</tt><br /> <tt></tt><br /></blockquote>
<tt>Changes to src/libical/icaltz-util.c do what I believe is correct which </tt><br /> <tt>is to specify DTSTART with reference to the "TZOFFSETFROM" UTC offset </tt><br /> <tt>rather than "TZOFFSETTO".</tt><br /> <tt></tt><br /> <tt>Regards and thanks in anticipation,</tt><br /> <tt>Gren.</tt><br /> <tt></tt><br /> <tt>-- </tt><br /> <tt>Gren Elliot</tt><br /> <tt>Senior Software Engineer</tt><br /> <tt>*Scalix*</tt><br /> <tt>gren.elliot@scalix.com</tt><br /> <tt>Tel: +44 1344 381812</tt><br /> <tt>www.scalix.com</tt><br /> <tt></tt><br /> <br />
<div class="display_inline_attachment"><img src="display_mime_icon?type=" border="0" alt="" align="middle" /> (, 0 bytes) <a href="mimepart_download/0">Herunterladen</a><br />
<div class="display_inline_attachment_body"></div>
</div>
<div class="display_inline_attachment"><img src="display_mime_icon?type=" border="0" alt="" align="middle" /> (, 0 bytes) <a href="mimepart_download/0">Herunterladen</a><br />
<div class="display_inline_attachment_body"></div>
</div>
<div class="display_inline_attachment"><img src="display_mime_icon?type=" border="0" alt="" align="middle" /> (, 0 bytes) <a href="mimepart_download/0">Herunterladen</a><br />
<div class="display_inline_attachment_body"></div>
</div>
</div>
</blockquote>
<p> </p>
</body></html>