<html><body>
<p>Hy Terry, </p><p>thanks for having a look. I think we'll let that WTF inside for at least one more release, as we first need to join them, before we can punish them ;-) </p><p>To be onest both versions of code in icalmimetype.c look suspect to me... that was the reason why i didn't know which one to prefer. I didn't have the time to investigate how i can trigger that code yet.<br /> </p><blockquote>Tue Jan 29 2008 21:01:20 CET from Terry Wilson to freeassociation-devel@lists.sourceforge.net <br />Subject: [Freeassociation-devel] [patch] TODOs in icalproperty.c and icalmime.c<br /><br />The TODO: WTF? in icalproperty.c seems to be just a deprecation<br />warning from when the name of the function icalproperty_get_name was<br />renamed to icalproperty_get_property_name--I'm assuming to be more in<br />line with the other function names. This seems to have been<br />deprecated since 2002. I did a search on krugle.org and it looks like<br />maybe a couple of instances in KDE might still use the old function<br />name, but of course it is a quick fix for them--I would say if<br />something has been deprecated for 6 years, you can safely remove it in<br />a new release. :-) Not that it hurts to keep it around, but why<br />deprecate something if you never intend to take it out, right? I'd<br />just say make them aware that it is really going away finally and<br />update the line or two of code that they use it for.<br /><br />The icalmimetype.c TODO is a little more confusing. It looks like the<br />evolution version might be the way to go as 'part' is dynamically<br />allocated by new_part and never freed anywhere if we use the KDE<br />version. I don't have time right now to try to whip something up and<br />test with valgrind, but it looks like the currently uncommented<br />version is the way to go to me. Looks like they were both trying to<br />solve the same issue, but went about it different ways (referencing<br />impl after freeing it).<br /><br />Attaching patches just for fun removing long-deprecated function and<br />removing commented out KDE version of icalmime_text_end_part().<br /><br /><br /></blockquote>
</body></html>