Inconsistencies in TZID values for builtin timezones

Allen Winter winter at kde.org
Sun Dec 20 13:04:49 EST 2020


On Tuesday, November 10, 2020 3:14:40 PM EST Milan Crha wrote:
> On Tue, 2020-11-10 at 06:48 -0500, Allen Winter wrote:
> > Let's not break too much at once.
> 
> 	Hi,
> okay, works for me. I made two patches. See the commit messages there.
> They are closely related and it's possible I did not split the change
> accurately (I would commit it as a single change, but I didn't know how
> to name it). In any case, when both patches are applied the `make test`
> passes all tests (including those for libical-glib) regardless whether
> USE_BUILTIN_TZDATA is set to ON or OFF.
> 
> I believe the changes make sense, even they can feel controversial a
> bit. Let me know if you'd like to change anything.
> 	Thanks and bye,
> 	Milan
> 
Thank you Milan.
I committed your patches to the 3.0 branch.
Assuming the travis and appveyor are happy I will merge them into master.








More information about the libical-devel mailing list