Use-after-free in 2.0.0 under icalrecur_iterator_new()

[Allen Winter]

icalrecur.c is under Ken's knowledge domain so I defer to his expertise on this patch.

On Thursday, February 11, 2016 03:11:34 PM Milan Crha wrote:
> On Wed, 2016-02-10 at 18:48 +0100, Milan Crha wrote:
> > I'm using libical 2.0.0 for testing and such and I realized that it's
> > easy to let the application
> 
> 	Hi,
> please find the attached proposed patch for the issue.
> 
> It defines a new private pool of strings being used
> for icalrecurrencetype::rscale. As the pool is shared by all threads,
> it is safe to pass the values between them.
> 
> The change fixed it for me, but I do not know whether it's good also
> for you. Please let me know.
> 
> If accepted, I guess it would be good to make a release, 2.0.1 (or
> 2.0.0.1?) with all the changes since 2.0.0 release, because some of
> them were critical (like the build break and eventually this one).
> 	Thanks and bye,
> 	Milan