[Freeassociation-devel] [PATCH] Re: Crash with attachment on libical 0.46

[Allen Winter]

I looked at this, and the problem stems from the fact that we currently
don't support the URI type for attachments as specified like this:

ATTACH;TYPE=URI:http://whatever

So attached is a little patch against icalparser.c that might fix this.
Please review the patch.


On Wednesday, August 17, 2011 01:39:21 am Milan Crha wrote:
> 	Hi,
> there is a Gnome bug [1], which reporter discovered an issue with
> libical, when it parses an event with URI attachments, then accessing
> the URI itself (through libical API) crashes the application. GDB claims
> that the memory returned by the icalattach_get_url() is not valid (its
> address is out of range). The memory pointer seems suspicious, and
> changing the URI itself to something else (by replacing certain letters
> with 'x' or similar letter in it results in a "not a URI attachment"
> parser result).
> 
> I was able to reproduce this with latest libical release (0.46), thus
> I'm reporting it to you.
> 
> See the attached test code, it contains good and bad event. One works as
> expected, the other not.
> 
> 	Bye,
> 	Milan
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=655120
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: icalparser.c.diff
Type: text/x-diff
Size: 640 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110820/4c6affc8/attachment.bin>