From patrick.ohly at gmx.de  Thu Aug 11 02:52:27 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Thu, 11 Aug 2011 11:52:27 +0200
Subject: [Freeassociation-devel] libical: TZID prefix
Message-ID: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>

Hello Allen!

I'm having some issue with the libical compiled from source which might
be related to your following commit:

commit 58333eb3d2a2001fd9f696bcb63e54ff604915c6
Author: awinterz <awinterz at b29e25b1-4845-0410-9c6e-9608a45a5811>
Date:   Sat Mar 19 20:51:06 2011 +0000

    don't put the tzid_prefixTzfile in the tzid  
    
    git-svn-id:
https://freeassociation.svn.sourceforge.net/svnroot/freeassociation/trunk at 1066 b29e25b1-4845-0410-9c6e-9608a45a5811

What was the rationale for no longer putting the prefix into the TZID?

The problem is that the following program fails because
icaltimezone_get_builtin_timezone_from_tzid() fails to resolve the
"Europe/Berlin" TZID:

----------------------------------
#include <libical/ical.h>
#include <stdio.h>
#include <string>

int main(int argc, char **argv)
{
    icaltimezone *tzdef = icaltimezone_get_builtin_timezone("Europe/Berlin");
    if (tzdef) {
      std::string tzid = icaltimezone_get_tzid(tzdef);
      printf("Europe/Berlin = TZID %s\n", tzid.c_str());
      tzdef = icaltimezone_get_builtin_timezone_from_tzid(tzid.c_str());
      printf("lookup by TZID %s\n", tzdef ? "okay" : "failed");
    }
    return 0;
}
----------------------------------

The easiest fix is to revert your commit above, but if the change is
important, a different solution needs to be found.

A quick check shows that the lookup fails because it expects the TZID to
have the prefix:

    /* Check that the TZID starts with our unique prefix. */
    if (strncmp (tzid, ical_tzid_prefix, strlen(ical_tzid_prefix)))
        return NULL;

That would have to be removed. But I'm a bit wary of other implications
of removing the TZID prefix and haven't tried that. SyncEvolution and
libsynthesis have not been tested with libical time zones without any
kind of prefix.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From winter at kde.org  Thu Aug 11 04:41:55 2011
From: winter at kde.org (Allen Winter)
Date: Thu, 11 Aug 2011 07:41:55 -0400
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108110741.56182.winter@kde.org>

On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> Hello Allen!
> 
> I'm having some issue with the libical compiled from source which might
> be related to your following commit:
> 
> commit 58333eb3d2a2001fd9f696bcb63e54ff604915c6
> Author: awinterz <awinterz at b29e25b1-4845-0410-9c6e-9608a45a5811>
> Date:   Sat Mar 19 20:51:06 2011 +0000
> 
>     don't put the tzid_prefixTzfile in the tzid  
>     
>     git-svn-id:
> https://freeassociation.svn.sourceforge.net/svnroot/freeassociation/trunk at 1066 b29e25b1-4845-0410-9c6e-9608a45a5811
> 
> What was the rationale for no longer putting the prefix into the TZID?
> 

I think I removed it because I didn't understand why it was there and
it was causing a failure in the regression tests.

I'll revert then.



> The problem is that the following program fails because
> icaltimezone_get_builtin_timezone_from_tzid() fails to resolve the
> "Europe/Berlin" TZID:
> 
> ----------------------------------
> #include <libical/ical.h>
> #include <stdio.h>
> #include <string>
> 
> int main(int argc, char **argv)
> {
>     icaltimezone *tzdef = icaltimezone_get_builtin_timezone("Europe/Berlin");
>     if (tzdef) {
>       std::string tzid = icaltimezone_get_tzid(tzdef);
>       printf("Europe/Berlin = TZID %s\n", tzid.c_str());
>       tzdef = icaltimezone_get_builtin_timezone_from_tzid(tzid.c_str());
>       printf("lookup by TZID %s\n", tzdef ? "okay" : "failed");
>     }
>     return 0;
> }
> ----------------------------------
> 
> The easiest fix is to revert your commit above, but if the change is
> important, a different solution needs to be found.
> 
> A quick check shows that the lookup fails because it expects the TZID to
> have the prefix:
> 
>     /* Check that the TZID starts with our unique prefix. */
>     if (strncmp (tzid, ical_tzid_prefix, strlen(ical_tzid_prefix)))
>         return NULL;
> 
> That would have to be removed. But I'm a bit wary of other implications
> of removing the TZID prefix and haven't tried that. SyncEvolution and
> libsynthesis have not been tested with libical time zones without any
> kind of prefix.
> 
> 

-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions



From winter at kde.org  Thu Aug 11 16:21:35 2011
From: winter at kde.org (Allen Winter)
Date: Thu, 11 Aug 2011 19:21:35 -0400
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108111921.36370.winter@kde.org>

On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> Hello Allen!
> 
> I'm having some issue with the libical compiled from source which might
> be related to your following commit:
> 
Ok, reverted in SVN commit r1083

Please try now and let me know if things work better.
regression test fails now btw.  I'll try to fix that once Patrick reports back.


> commit 58333eb3d2a2001fd9f696bcb63e54ff604915c6
> Author: awinterz <awinterz at b29e25b1-4845-0410-9c6e-9608a45a5811>
> Date:   Sat Mar 19 20:51:06 2011 +0000
> 
>     don't put the tzid_prefixTzfile in the tzid  
>     
>     git-svn-id:
> https://freeassociation.svn.sourceforge.net/svnroot/freeassociation/trunk at 1066 b29e25b1-4845-0410-9c6e-9608a45a5811
> 
> What was the rationale for no longer putting the prefix into the TZID?
> 
> The problem is that the following program fails because
> icaltimezone_get_builtin_timezone_from_tzid() fails to resolve the
> "Europe/Berlin" TZID:
> 
> ----------------------------------
> #include <libical/ical.h>
> #include <stdio.h>
> #include <string>
> 
> int main(int argc, char **argv)
> {
>     icaltimezone *tzdef = icaltimezone_get_builtin_timezone("Europe/Berlin");
>     if (tzdef) {
>       std::string tzid = icaltimezone_get_tzid(tzdef);
>       printf("Europe/Berlin = TZID %s\n", tzid.c_str());
>       tzdef = icaltimezone_get_builtin_timezone_from_tzid(tzid.c_str());
>       printf("lookup by TZID %s\n", tzdef ? "okay" : "failed");
>     }
>     return 0;
> }
> ----------------------------------
> 
> The easiest fix is to revert your commit above, but if the change is
> important, a different solution needs to be found.
> 
> A quick check shows that the lookup fails because it expects the TZID to
> have the prefix:
> 
>     /* Check that the TZID starts with our unique prefix. */
>     if (strncmp (tzid, ical_tzid_prefix, strlen(ical_tzid_prefix)))
>         return NULL;
> 
> That would have to be removed. But I'm a bit wary of other implications
> of removing the TZID prefix and haven't tried that. SyncEvolution and
> libsynthesis have not been tested with libical time zones without any
> kind of prefix.
> 
> 

-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions



From patrick.ohly at gmx.de  Thu Aug 11 23:49:42 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Fri, 12 Aug 2011 08:49:42 +0200
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <201108111921.36370.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
Message-ID: <1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>

On Do, 2011-08-11 at 19:21 -0400, Allen Winter wrote:
> On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> > Hello Allen!
> > 
> > I'm having some issue with the libical compiled from source which might
> > be related to your following commit:
> > 
> Ok, reverted in SVN commit r1083
> 
> Please try now and let me know if things work better.

I can't test that particular commit because the nightly test machine
went down and I cannot reset it remotely myself. But I had already
tested with a version where I reverted the commit myself. I can confirm
that this fixes the problem for me.

> regression test fails now btw.  I'll try to fix that once Patrick reports back.

Please continue.

I'll keep testing the latest libical in combination with libecal, EDS
and SyncEvolution more regularly now. What's the plan for the next
release?

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From winter at kde.org  Fri Aug 12 17:23:48 2011
From: winter at kde.org (Allen Winter)
Date: Fri, 12 Aug 2011 20:23:48 -0400
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108122023.48753.winter@kde.org>

On Friday 12 August 2011 2:49:42 AM Patrick Ohly wrote:
> On Do, 2011-08-11 at 19:21 -0400, Allen Winter wrote:
> > On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> > > Hello Allen!
> > > 
> > > I'm having some issue with the libical compiled from source which might
> > > be related to your following commit:
> > > 
> > Ok, reverted in SVN commit r1083
> > 
> > Please try now and let me know if things work better.
> 
> I can't test that particular commit because the nightly test machine
> went down and I cannot reset it remotely myself. But I had already
> tested with a version where I reverted the commit myself. I can confirm
> that this fixes the problem for me.
> 
> > regression test fails now btw.  I'll try to fix that once Patrick reports back.
> 
> Please continue.
> 

I think I fixed the regression test.
There was a bug in icaltimezone_get_builtin_timezone_from_tzid()
that didn't skip past the "/Tzfile" when extracting the location from the TZID.

> I'll keep testing the latest libical in combination with libecal, EDS
> and SyncEvolution more regularly now. 

Yes please.  I encourage everyone to test on as many different platforms as they have access to.

> What's the plan for the next release?
> 
I don't know. Maybe Art does.
But I really would like to hold off until I hear something ANYTHING from the Windows and Mac testers.

Also a couple of new bug reports and patches have come in over the past few weeks that should be looked at.



-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions



From pva at gentoo.org  Sat Aug 13 05:14:22 2011
From: pva at gentoo.org (Peter Volkov)
Date: Sat, 13 Aug 2011 16:14:22 +0400
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <201108122023.48753.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
	<201108122023.48753.winter@kde.org>
Message-ID: <1313237662.7527.16.camel@tablet>

? ???, 12/08/2011 ? 20:23 -0400, Allen Winter ?????:
> > What's the plan for the next release?
> > 
> I don't know. Maybe Art does.
> But I really would like to hold off until I hear something ANYTHING
> from the Windows and Mac testers.

If there is really need in such feedback, it's better to "release early,
release often":
http://en.wikipedia.org/wiki/Release_early,_release_often

Keeping lot's of changes unreleased creates hidden regressions which
will be harder to debug. That said I don't want to push release.
Actually I think that test suite is really critical in this time related
software :)

Cheers,
--
Peter.




From room_libical at uncensored.citadel.org  Mon Aug 15 09:33:21 2011
From: room_libical at uncensored.citadel.org (IGnatius T Foobar)
Date: Mon, 15 Aug 2011 12:33:21 -0400
Subject: [Freeassociation-devel] libical: TZID prefix
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
	<201108122023.48753.winter@kde.org>
	<1313237662.7527.16.camel@tablet>
Message-ID: <4E494A51-002DF491@uncensored.citadel.org>

 >> > What's the plan for the next release?  
 >> >   
 >> I don't know. Maybe Art does.  
 >> But I really would like to hold off until I hear something ANYTHING  
 >> from the Windows and Mac testers.  
  
 I am ready to do a release at this time.  I was holding off as a courtesy
towards Allen because he requested more testing from the Windows/Mac testers.

  
 -- Art 
 



From patrick.ohly at gmx.de  Tue Aug 16 04:03:29 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Tue, 16 Aug 2011 13:03:29 +0200
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <201108122023.48753.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
	<201108122023.48753.winter@kde.org>
Message-ID: <1313492609.10938.44.camel@pohly-mobl1.ikn.intel.com>

On Fri, 2011-08-12 at 20:23 -0400, Allen Winter wrote:
> On Friday 12 August 2011 2:49:42 AM Patrick Ohly wrote:
> > On Do, 2011-08-11 at 19:21 -0400, Allen Winter wrote:
> > > On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> > > > Hello Allen!
> > > > 
> > > > I'm having some issue with the libical compiled from source which might
> > > > be related to your following commit:
> > > > 
> > > Ok, reverted in SVN commit r1083
> > > 
> > > Please try now and let me know if things work better.
> > 
> > I can't test that particular commit because the nightly test machine
> > went down and I cannot reset it remotely myself. But I had already
> > tested with a version where I reverted the commit myself. I can confirm
> > that this fixes the problem for me.
> > 
> > > regression test fails now btw.  I'll try to fix that once Patrick reports back.
> > 
> > Please continue.
> > 
> 
> I think I fixed the regression test.
> There was a bug in icaltimezone_get_builtin_timezone_from_tzid()
> that didn't skip past the "/Tzfile" when extracting the location from the TZID.

Your fix is:

commit a65a0894ce7cf9672f9837dd38a95bbcba84b49b
Author: awinterz <awinterz at b29e25b1-4845-0410-9c6e-9608a45a5811>
Date:   Sat Aug 13 00:11:14 2011 +0000

    in icaltimezone_get_builtin_timezone_from_tzid(), skip past the 4th '/' character
    to find the location from the tzid, not the 3rd '/' character.  This is needed
    because there has been a "/Tzfile" encoded into the tzid as of late.
    
    fixes the 'test_convenience' regression test.

But that is not correct for the TZID as produced by the latest libical.
In the test program from my initial email, I get
TZID /freeassociation.sourceforge.net/Tzfile/Europe/Berlin. With the
commit above, icaltimezone_get_builtin_timezone_from_tzid() skips
forward to the "Berlin" part, which then fails to be found.

I fail to see how the commit relates to the 'test_convenience'. Isn't
that the one which uses
icaltimezone_get_builtin_timezone("Europe/Rome")? Is
icaltimezone_get_builtin_timezone_from_tzid() used indirectly in that
test?

[talking to myself while looking at the source...]

Yes, that's it. The tests call
icaltimezone_get_builtin_timezone_from_tzid() like this:

#0  icaltimezone_get_builtin_timezone_from_tzid (
    tzid=0x62d1f0 "/softwarestudio.org/Olson_20010626_2/Tzfile/Europe/Rome")
    at /home/nightly/freeassociation/libical/src/libical/icaltimezone.c:1468
#1  0x00007ffff777c3c8 in icalcomponent_get_datetime (comp=<value optimized out>, prop=<value optimized out>)
    at /home/nightly/freeassociation/libical/src/libical/icalcomponent.c:1587
#2  0x00007ffff777c41c in icalcomponent_get_dtstart (comp=0x6288f0)
    at /home/nightly/freeassociation/libical/src/libical/icalcomponent.c:1615
#3  0x0000000000407d79 in test_convenience () at /home/nightly/freeassociation/libical/src/test/regression.c:2282
#4  0x0000000000416f5a in test_run (test_name=<value optimized out>, test_fcn=0x406c40 <test_convenience>, 
    do_test=0, headeronly=<value optimized out>)
    at /home/nightly/freeassociation/libical/src/test/regression-utils.c:170
#5  0x0000000000406b37 in main (argc=<value optimized out>, argv=0x7fffffffdff8)
    at /home/nightly/freeassociation/libical/src/test/regression.c:3813

The problem is that
"/softwarestudio.org/Olson_20010626_2/Tzfile/Europe/Rome" is not an
internal TZID for which icaltimezone_get_builtin_timezone_from_tzid() is
meant to work - at least when internal timezones are taken from the zone
database.

Allen, were you perhaps testing on a system where internal TZIDs are not
of the form /freeassociation.sourceforge.net/Tzfile/Europe/Berlin? How
did you make strcmp("1997-08-01 12:00:00 Europe/Rome", ictt_as_string())
pass in test_convenience? In my understanding of the source it'll always
insert the TZID, which is not Europe/Rome either way.

I'm not sure what the right solution is:
     1. Use three slashes consistently, including all tests?
     2. Use four slashes consistently, including icaltz-util.c?
     3. #ifdefs?

Attached a patch which implements solution 1. I chose to go that route
because the format /<source>/<version>/<location>/ seems to be the
established one, with "Tzfile" taking the place of <version> when
parsing zone info. Adding one more slash would introduce an unnecessary
change compared to previous libical releases, too.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-in-icaltimezone_get_builtin_timezone_from_tzi.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110816/c8249927/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-regression-fixed-test_convenience.patch
Type: text/x-patch
Size: 1905 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110816/c8249927/attachment-0001.bin>

From patrick.ohly at gmx.de  Tue Aug 16 04:52:12 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Tue, 16 Aug 2011 13:52:12 +0200
Subject: [Freeassociation-devel] libical release planning (was: Re: libical:
 TZID prefix)
In-Reply-To: <4E494A51-002DF491@uncensored.citadel.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
	<201108122023.48753.winter@kde.org> <1313237662.7527.16.camel@tablet>
	<4E494A51-002DF491@uncensored.citadel.org>
Message-ID: <1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>

On Mon, 2011-08-15 at 12:33 -0400, IGnatius T Foobar wrote:
> >> > What's the plan for the next release?  
>  >> >   
>  >> I don't know. Maybe Art does.  
>  >> But I really would like to hold off until I hear something ANYTHING  
>  >> from the Windows and Mac testers.  
>   
>  I am ready to do a release at this time.  I was holding off as a courtesy
> towards Allen because he requested more testing from the Windows/Mac testers.

I agree with Peter that it is better to release early and often. If the
next release does not work for Windows/Mac users, then they can stay
with the older version until the problem (whatever it'll be) is fixed.

One valid reason to delay a release is that testing actively happens
and/or regressions are known which are considered release critical and
there is a solution in sight.

With libical, both is the case right now: I am still testing it on Linux
with EDS/SyncEvolution *and* the TZID problem is still open. See my
other email on that.

So let's focus on that and release in about a week?

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From room_libical at uncensored.citadel.org  Tue Aug 16 04:39:47 2011
From: room_libical at uncensored.citadel.org (dothebart)
Date: Tue, 16 Aug 2011 07:39:47 -0400
Subject: [Freeassociation-devel] (no subject)
Message-ID: <4E4A5703-002DF52E@uncensored.citadel.org>

An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110816/d5592947/attachment.html>

From mcrha at redhat.com  Tue Aug 16 22:39:21 2011
From: mcrha at redhat.com (Milan Crha)
Date: Wed, 17 Aug 2011 07:39:21 +0200
Subject: [Freeassociation-devel] Crash with attachment on libical 0.46
Message-ID: <1313559562.14299.7.camel@localhost>

	Hi,
there is a Gnome bug [1], which reporter discovered an issue with
libical, when it parses an event with URI attachments, then accessing
the URI itself (through libical API) crashes the application. GDB claims
that the memory returned by the icalattach_get_url() is not valid (its
address is out of range). The memory pointer seems suspicious, and
changing the URI itself to something else (by replacing certain letters
with 'x' or similar letter in it results in a "not a URI attachment"
parser result).

I was able to reproduce this with latest libical release (0.46), thus
I'm reporting it to you.

See the attached test code, it contains good and bad event. One works as
expected, the other not.

	Bye,
	Milan

[1] https://bugzilla.gnome.org/show_bug.cgi?id=655120
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a.c
Type: text/x-csrc
Size: 2729 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110817/f3d56c66/attachment.bin>

From winter at kde.org  Wed Aug 17 04:32:28 2011
From: winter at kde.org (Allen Winter)
Date: Wed, 17 Aug 2011 07:32:28 -0400
Subject: [Freeassociation-devel] libical release planning (was: Re:
	libical: TZID prefix)
In-Reply-To: <1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<4E494A51-002DF491@uncensored.citadel.org>
	<1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108170732.30207.winter@kde.org>

On Tuesday 16 August 2011 7:52:12 AM Patrick Ohly wrote:
> On Mon, 2011-08-15 at 12:33 -0400, IGnatius T Foobar wrote:
> > >> > What's the plan for the next release?  
> >  >> >   
> >  >> I don't know. Maybe Art does.  
> >  >> But I really would like to hold off until I hear something ANYTHING  
> >  >> from the Windows and Mac testers.  
> >   
> >  I am ready to do a release at this time.  I was holding off as a courtesy
> > towards Allen because he requested more testing from the Windows/Mac testers.
> 
> I agree with Peter that it is better to release early and often. If the
> next release does not work for Windows/Mac users, then they can stay
> with the older version until the problem (whatever it'll be) is fixed.
> 
> One valid reason to delay a release is that testing actively happens
> and/or regressions are known which are considered release critical and
> there is a solution in sight.
> 
> With libical, both is the case right now: I am still testing it on Linux
> with EDS/SyncEvolution *and* the TZID problem is still open. See my
> other email on that.
> 
> So let's focus on that and release in about a week?
> 

At least lets' do some testing besides just Patrick and myself.
There have quite some changes.

It's one thing to release something we feel pretty confident about.
It's quite another to just throw code out there that people already
use and rely on as a stable library.

I strongly oppose any release at this time until there is more internal testing
on a variety of platforms.  Windows included.

Please test and report back here what you found.

-Allen



From patrick.ohly at gmx.de  Wed Aug 17 06:58:15 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Wed, 17 Aug 2011 15:58:15 +0200
Subject: [Freeassociation-devel] libical release planning (was: Re:
 libical: TZID prefix)
In-Reply-To: <201108170732.30207.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<4E494A51-002DF491@uncensored.citadel.org>
	<1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
Message-ID: <1313589495.10938.133.camel@pohly-mobl1.ikn.intel.com>

On Wed, 2011-08-17 at 07:32 -0400, Allen Winter wrote:
> On Tuesday 16 August 2011 7:52:12 AM Patrick Ohly wrote:
> > With libical, both is the case right now: I am still testing it on Linux
> > with EDS/SyncEvolution *and* the TZID problem is still open. See my
> > other email on that.
> > 
> > So let's focus on that and release in about a week?
> > 
> 
> At least lets' do some testing besides just Patrick and myself.
> There have quite some changes.
> 
> It's one thing to release something we feel pretty confident about.
> It's quite another to just throw code out there that people already
> use and rely on as a stable library.
> 
> I strongly oppose any release at this time until there is more internal testing
> on a variety of platforms.  Windows included.
> 
> Please test and report back here what you found.

But what if that testing isn't happening? Never release another update?

Part of the motivation for the "release early, release often" guideline
is that users (which are more likely developers and distributors in the
case of libical) are not going to do the testing unless a release is cut
first. Classic chicken-and-egg problem.

If you can get people to do the testing before-hand, great, but if not,
then doing the release and being prepared to follow up quickly with
fixes for problems found after the release is one way out of the
deadlock.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From winter at kde.org  Wed Aug 17 10:40:17 2011
From: winter at kde.org (Allen Winter)
Date: Wed, 17 Aug 2011 13:40:17 -0400
Subject: [Freeassociation-devel] libical release planning (was: Re:
	libical: TZID prefix)
In-Reply-To: <1313589495.10938.133.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
	<1313589495.10938.133.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108171340.18494.winter@kde.org>

On Wednesday 17 August 2011 9:58:15 AM you wrote:
> On Wed, 2011-08-17 at 07:32 -0400, Allen Winter wrote:
> > On Tuesday 16 August 2011 7:52:12 AM Patrick Ohly wrote:
> > > With libical, both is the case right now: I am still testing it on Linux
> > > with EDS/SyncEvolution *and* the TZID problem is still open. See my
> > > other email on that.
> > > 
> > > So let's focus on that and release in about a week?
> > > 
> > 
> > At least lets' do some testing besides just Patrick and myself.
> > There have quite some changes.
> > 
> > It's one thing to release something we feel pretty confident about.
> > It's quite another to just throw code out there that people already
> > use and rely on as a stable library.
> > 
> > I strongly oppose any release at this time until there is more internal testing
> > on a variety of platforms.  Windows included.
> > 
> > Please test and report back here what you found.
> 
> But what if that testing isn't happening? Never release another update?
> 
> Part of the motivation for the "release early, release often" guideline
> is that users (which are more likely developers and distributors in the
> case of libical) are not going to do the testing unless a release is cut
> first. Classic chicken-and-egg problem.
> 
> If you can get people to do the testing before-hand, great, but if not,
> then doing the release and being prepared to follow up quickly with
> fixes for problems found after the release is one way out of the
> deadlock.
> 
I'm not budging on my position.
I did almost all the work since the last release so I'm deciding.

Art can take away my admin status if he likes.  But that's how I feel about it.





From room_libical at uncensored.citadel.org  Wed Aug 17 13:55:46 2011
From: room_libical at uncensored.citadel.org (Wilfried Goesgens)
Date: Wed, 17 Aug 2011 16:55:46 -0400
Subject: [Freeassociation-devel]
	=?utf-8?q?libical_release_planning_=28was?=
	=?utf-8?b?OiBSZToJbGliaWNhbDogVFpJRCBwcmVmaXgp?=
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
	<1313589495.10938.133.camel@pohly-mobl1.ikn.intel.com>
	<201108171340.18494.winter@kde.org>
Message-ID: <4E4C2AD2-002DF765@uncensored.citadel.org>

An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110817/7f7eeb97/attachment.html>

From room_libical at uncensored.citadel.org  Wed Aug 17 17:14:33 2011
From: room_libical at uncensored.citadel.org (IGnatius T Foobar)
Date: Wed, 17 Aug 2011 20:14:33 -0400
Subject: [Freeassociation-devel] libical release planning (was:
	Re:	libical: TZID prefix)
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<4E494A51-002DF491@uncensored.citadel.org>
	<1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
Message-ID: <4E4C5969-002DF7AD@uncensored.citadel.org>

 >At least lets' do some testing besides just Patrick and myself.  
 >There have quite some changes.  
  
 Actually, I test libical on a more or less continual basis.  The development
hosts that I use for building Citadel are also tracking libical, so if a bug
appears that seems to be libical related, I will know about it and post it
here. 
  
 So yes, there is more testing going on than just the two of you  :) 
  
 However, I do not have the ability to test on Windows or Mac. 
  
   -- Art 
 



From pva at gentoo.org  Wed Aug 17 22:15:48 2011
From: pva at gentoo.org (Peter Volkov)
Date: Thu, 18 Aug 2011 09:15:48 +0400
Subject: [Freeassociation-devel] libical release planning (was: Re:
 libical: TZID prefix)
In-Reply-To: <201108170732.30207.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<4E494A51-002DF491@uncensored.citadel.org>
	<1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
Message-ID: <1313644548.20964.2.camel@tablet>

? ???, 17/08/2011 ? 07:32 -0400, Allen Winter ?????:
> At least lets' do some testing besides just Patrick and myself.
> There have quite some changes.
> 
> It's one thing to release something we feel pretty confident about.
> It's quite another to just throw code out there that people already
> use and rely on as a stable library.
> 
> I strongly oppose any release at this time until there is more internal testing
> on a variety of platforms.  Windows included.

The common solution is to push release candidate. Then in the
announcement for RC it's common to request testing (with some guidelines
what testing are you interested in specifically).

--
Peter.




From patrick.ohly at gmx.de  Wed Aug 17 23:22:33 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Thu, 18 Aug 2011 08:22:33 +0200
Subject: [Freeassociation-devel] libical release planning (was: Re:
 libical: TZID prefix)
In-Reply-To: <4E4C2AD2-002DF765@uncensored.citadel.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
	<1313589495.10938.133.camel@pohly-mobl1.ikn.intel.com>
	<201108171340.18494.winter@kde.org>
	<4E4C2AD2-002DF765@uncensored.citadel.org>
Message-ID: <1313648553.15645.8.camel@pohly-mobl1.ikn.intel.com>

On Mi, 2011-08-17 at 16:55 -0400, Wilfried Goesgens wrote:
>         Mi Aug 17 2011 13:40:17 EDT von "Allen Winter"
>         <winter at kde.org> Betreff: Re: [Freeassociation-devel] libical
>         release planning (was: Re: libical: TZID prefix)
>         On Wednesday 17 August 2011 9:58:15 AM you wrote:
>         I'm not budging on my position.
>         I did almost all the work since the last release so I'm
>         deciding.
>         
>         Art can take away my admin status if he likes. But that's how
>         I feel about it.

Allen, your work is definitely appreciated. I just wanted to offer a
different point of view on how libical might be moved forward.

> there are however some memleak bugfixes sponsored by nokia/intel since
> the last release, which is probably what Patrick is talking about.

Correct. My hope was that at some point I can stop suppressing known
issues in libical when testing the stick libical in a recent distro ;-)

> while the windows platform might be important for the k* and evolution
> ports, its obviously not for mameo (->Patrick) or citadel (me and Art)

I doubt that Evolution on Windows has much relevance.

> in the first two cases i'd be in for waiting for a go from you, which
> probably also Patrick and Art can accept.

Absolutely. I just want to avoid the case where the next release gets
delayed indefinitely because no-one is doing that testing on Windows and
Mac.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From bradh at frogmouth.net  Thu Aug 18 03:11:47 2011
From: bradh at frogmouth.net (Brad Hards)
Date: Thu, 18 Aug 2011 20:11:47 +1000
Subject: [Freeassociation-devel] libical release planning (was: Re:
	libical: TZID prefix)
In-Reply-To: <201108170732.30207.winter@kde.org>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<1313495532.10938.50.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
Message-ID: <201108182011.47491.bradh@frogmouth.net>

On Wednesday 17 August 2011 21:32:28 Allen Winter wrote:
> Please test and report back here what you found.
Exactly what would you like tested? svn from
https://freeassociation.svn.sourceforge.net/svnroot/freeassociation/trunk
?

or a branch?

Brad



From bradh at frogmouth.net  Thu Aug 18 03:30:33 2011
From: bradh at frogmouth.net (Brad Hards)
Date: Thu, 18 Aug 2011 20:30:33 +1000
Subject: [Freeassociation-devel] [patch] trivial warning fix
Message-ID: <201108182030.33644.bradh@frogmouth.net>

There are quite a lot of warnings in a (cmake) build of libical from trunk.

This fixes just one.
Index: src/test/regression.c
===================================================================
--- src/test/regression.c       (revision 1088)
+++ src/test/regression.c       (working copy)
@@ -567,7 +567,7 @@
 
       printf("Final: %s\n", f);
 
-      printf("Final buffer size: %d\n",bufsize);
+      printf("Final buffer size: %zd\n", bufsize);
     }
 
     ok("final buffer size == 806", (bufsize == 806));



From winter at kde.org  Fri Aug 19 06:05:23 2011
From: winter at kde.org (Allen Winter)
Date: Fri, 19 Aug 2011 09:05:23 -0400
Subject: [Freeassociation-devel] libical release planning (was: Re:
	libical: TZID prefix)
In-Reply-To: <201108182011.47491.bradh@frogmouth.net>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108170732.30207.winter@kde.org>
	<201108182011.47491.bradh@frogmouth.net>
Message-ID: <201108190905.25155.winter@kde.org>

On Thursday 18 August 2011 6:11:47 AM Brad Hards wrote:
> On Wednesday 17 August 2011 21:32:28 Allen Winter wrote:
> > Please test and report back here what you found.
> Exactly what would you like tested? svn from
> https://freeassociation.svn.sourceforge.net/svnroot/freeassociation/trunk
> ?
> 
> or a branch?

For the Windows and Mac testing, please use the windows-test branch.


> 
> Brad
> 
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
> user administration capabilities and model configuration. Take 
> the hassle out of deploying and managing Subversion and the 
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel
> 

-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions



From winter at kde.org  Sat Aug 20 09:02:32 2011
From: winter at kde.org (Allen Winter)
Date: Sat, 20 Aug 2011 12:02:32 -0400
Subject: [Freeassociation-devel] [patch] trivial warning fix
In-Reply-To: <201108182030.33644.bradh@frogmouth.net>
References: <201108182030.33644.bradh@frogmouth.net>
Message-ID: <201108201202.32639.winter@kde.org>

Thanks. Committed to trunk and to the windows-test branch

On Thursday, August 18, 2011 06:30:33 am Brad Hards wrote:
> There are quite a lot of warnings in a (cmake) build of libical from trunk.
> 
> This fixes just one.
> Index: src/test/regression.c
> ===================================================================
> --- src/test/regression.c       (revision 1088)
> +++ src/test/regression.c       (working copy)
> @@ -567,7 +567,7 @@
>  
>        printf("Final: %s\n", f);
>  
> -      printf("Final buffer size: %d\n",bufsize);
> +      printf("Final buffer size: %zd\n", bufsize);
>      }
>  
>      ok("final buffer size == 806", (bufsize == 806));
> 
> ------------------------------------------------------------------------------
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
> user administration capabilities and model configuration. Take 
> the hassle out of deploying and managing Subversion and the 
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel
> 




From winter at kde.org  Sat Aug 20 10:07:22 2011
From: winter at kde.org (Allen Winter)
Date: Sat, 20 Aug 2011 13:07:22 -0400
Subject: [Freeassociation-devel] [PATCH] Re: Crash with attachment on
	libical 0.46
In-Reply-To: <1313559562.14299.7.camel@localhost>
References: <1313559562.14299.7.camel@localhost>
Message-ID: <201108201307.22668.winter@kde.org>


I looked at this, and the problem stems from the fact that we currently
don't support the URI type for attachments as specified like this:

ATTACH;TYPE=URI:http://whatever

So attached is a little patch against icalparser.c that might fix this.
Please review the patch.


On Wednesday, August 17, 2011 01:39:21 am Milan Crha wrote:
> 	Hi,
> there is a Gnome bug [1], which reporter discovered an issue with
> libical, when it parses an event with URI attachments, then accessing
> the URI itself (through libical API) crashes the application. GDB claims
> that the memory returned by the icalattach_get_url() is not valid (its
> address is out of range). The memory pointer seems suspicious, and
> changing the URI itself to something else (by replacing certain letters
> with 'x' or similar letter in it results in a "not a URI attachment"
> parser result).
> 
> I was able to reproduce this with latest libical release (0.46), thus
> I'm reporting it to you.
> 
> See the attached test code, it contains good and bad event. One works as
> expected, the other not.
> 
> 	Bye,
> 	Milan
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=655120
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: icalparser.c.diff
Type: text/x-diff
Size: 640 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110820/4c6affc8/attachment.bin>

From mcrha at redhat.com  Mon Aug 22 00:22:42 2011
From: mcrha at redhat.com (Milan Crha)
Date: Mon, 22 Aug 2011 09:22:42 +0200
Subject: [Freeassociation-devel] [PATCH] Re: Crash with attachment on
 libical 0.46
In-Reply-To: <201108201307.22668.winter@kde.org>
References: <1313559562.14299.7.camel@localhost>
	<201108201307.22668.winter@kde.org>
Message-ID: <1313997764.7379.1.camel@localhost>

On Sat, 2011-08-20 at 13:07 -0400, Allen Winter wrote:
> I looked at this, and the problem stems from the fact that we currently
> don't support the URI type for attachments as specified like this:
> 
> ATTACH;TYPE=URI:http://whatever
> 
> So attached is a little patch against icalparser.c that might fix this.
> Please review the patch.

	Hi,
thanks for a quick reply. The patch works fine here, the URI is read and
the application doesn't crash anymore.
	Thanks and bye,
	Milan




From room_libical at uncensored.citadel.org  Mon Aug 22 12:01:14 2011
From: room_libical at uncensored.citadel.org (IGnatius T Foobar)
Date: Mon, 22 Aug 2011 15:01:14 -0400
Subject: [Freeassociation-devel] Testing
Message-ID: <4E52A77A-002E008C@uncensored.citadel.org>

  
 Just as an FYI -- testing of the current trunk (as of today) is presenting
no obvious bugs when the library is used with Citadel on Linux.  That's probably
status quo but it serves as a confirmation that the build does not seem to
be broken at this time.  I will continue to test. 
  
  -- Art 
 



From patrick.ohly at gmx.de  Tue Aug 23 02:25:23 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Tue, 23 Aug 2011 11:25:23 +0200
Subject: [Freeassociation-devel] libical: TZID prefix
In-Reply-To: <1313492609.10938.44.camel@pohly-mobl1.ikn.intel.com>
References: <1313056347.4723.263.camel@pohly-mobl1.ikn.intel.com>
	<201108111921.36370.winter@kde.org>
	<1313131782.4723.294.camel@pohly-mobl1.ikn.intel.com>
	<201108122023.48753.winter@kde.org>
	<1313492609.10938.44.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <1314091523.15645.208.camel@pohly-mobl1.ikn.intel.com>

Hello!

Any comments on this? It's still broken in Trunk.

Bye, Patrick

On Di, 2011-08-16 at 13:03 +0200, Patrick Ohly wrote:
> On Fri, 2011-08-12 at 20:23 -0400, Allen Winter wrote:
> > On Friday 12 August 2011 2:49:42 AM Patrick Ohly wrote:
> > > On Do, 2011-08-11 at 19:21 -0400, Allen Winter wrote:
> > > > On Thursday 11 August 2011 5:52:27 AM Patrick Ohly wrote:
> > > > > Hello Allen!
> > > > > 
> > > > > I'm having some issue with the libical compiled from source which might
> > > > > be related to your following commit:
> > > > > 
> > > > Ok, reverted in SVN commit r1083
> > > > 
> > > > Please try now and let me know if things work better.
> > > 
> > > I can't test that particular commit because the nightly test machine
> > > went down and I cannot reset it remotely myself. But I had already
> > > tested with a version where I reverted the commit myself. I can confirm
> > > that this fixes the problem for me.
> > > 
> > > > regression test fails now btw.  I'll try to fix that once Patrick reports back.
> > > 
> > > Please continue.
> > > 
> > 
> > I think I fixed the regression test.
> > There was a bug in icaltimezone_get_builtin_timezone_from_tzid()
> > that didn't skip past the "/Tzfile" when extracting the location from the TZID.
> 
> Your fix is:
> 
> commit a65a0894ce7cf9672f9837dd38a95bbcba84b49b
> Author: awinterz <awinterz at b29e25b1-4845-0410-9c6e-9608a45a5811>
> Date:   Sat Aug 13 00:11:14 2011 +0000
> 
>     in icaltimezone_get_builtin_timezone_from_tzid(), skip past the 4th '/' character
>     to find the location from the tzid, not the 3rd '/' character.  This is needed
>     because there has been a "/Tzfile" encoded into the tzid as of late.
>     
>     fixes the 'test_convenience' regression test.
> 
> But that is not correct for the TZID as produced by the latest libical.
> In the test program from my initial email, I get
> TZID /freeassociation.sourceforge.net/Tzfile/Europe/Berlin. With the
> commit above, icaltimezone_get_builtin_timezone_from_tzid() skips
> forward to the "Berlin" part, which then fails to be found.
> 
> I fail to see how the commit relates to the 'test_convenience'. Isn't
> that the one which uses
> icaltimezone_get_builtin_timezone("Europe/Rome")? Is
> icaltimezone_get_builtin_timezone_from_tzid() used indirectly in that
> test?
> 
> [talking to myself while looking at the source...]
> 
> Yes, that's it. The tests call
> icaltimezone_get_builtin_timezone_from_tzid() like this:
> 
> #0  icaltimezone_get_builtin_timezone_from_tzid (
>     tzid=0x62d1f0 "/softwarestudio.org/Olson_20010626_2/Tzfile/Europe/Rome")
>     at /home/nightly/freeassociation/libical/src/libical/icaltimezone.c:1468
> #1  0x00007ffff777c3c8 in icalcomponent_get_datetime (comp=<value optimized out>, prop=<value optimized out>)
>     at /home/nightly/freeassociation/libical/src/libical/icalcomponent.c:1587
> #2  0x00007ffff777c41c in icalcomponent_get_dtstart (comp=0x6288f0)
>     at /home/nightly/freeassociation/libical/src/libical/icalcomponent.c:1615
> #3  0x0000000000407d79 in test_convenience () at /home/nightly/freeassociation/libical/src/test/regression.c:2282
> #4  0x0000000000416f5a in test_run (test_name=<value optimized out>, test_fcn=0x406c40 <test_convenience>, 
>     do_test=0, headeronly=<value optimized out>)
>     at /home/nightly/freeassociation/libical/src/test/regression-utils.c:170
> #5  0x0000000000406b37 in main (argc=<value optimized out>, argv=0x7fffffffdff8)
>     at /home/nightly/freeassociation/libical/src/test/regression.c:3813
> 
> The problem is that
> "/softwarestudio.org/Olson_20010626_2/Tzfile/Europe/Rome" is not an
> internal TZID for which icaltimezone_get_builtin_timezone_from_tzid() is
> meant to work - at least when internal timezones are taken from the zone
> database.
> 
> Allen, were you perhaps testing on a system where internal TZIDs are not
> of the form /freeassociation.sourceforge.net/Tzfile/Europe/Berlin? How
> did you make strcmp("1997-08-01 12:00:00 Europe/Rome", ictt_as_string())
> pass in test_convenience? In my understanding of the source it'll always
> insert the TZID, which is not Europe/Rome either way.
> 
> I'm not sure what the right solution is:
>      1. Use three slashes consistently, including all tests?
>      2. Use four slashes consistently, including icaltz-util.c?
>      3. #ifdefs?
> 
> Attached a patch which implements solution 1. I chose to go that route
> because the format /<source>/<version>/<location>/ seems to be the
> established one, with "Tzfile" taking the place of <version> when
> parsing zone info. Adding one more slash would introduce an unnecessary
> change compared to previous libical releases, too.
> 
> ------------------------------------------------------------------------------
> uberSVN's rich system and user administration capabilities and model 
> configuration take the hassle out of deploying and managing Subversion and 
> the tools developers use with it. Learn more about uberSVN and get a free 
> download at:  http://p.sf.net/sfu/wandisco-dev2dev
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel





From garethcoco at gmail.com  Tue Aug 23 09:15:25 2011
From: garethcoco at gmail.com (Gareth Coco)
Date: Tue, 23 Aug 2011 12:15:25 -0400
Subject: [Freeassociation-devel] Testing on Windows
Message-ID: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>

Hi,

I have tested using MinGW cross compiling environment
(http://mingw-cross-env.nongnu.org) and the initial build failed.

To get around this I had to add the following:

#include <stddef.h> /* For ptrdiff_h */

to both:

src/libicalvcal/libicalvcal.c
src/libicalvcal/vcc.c

Once done the libs compile and make test passes all tests.



From garethcoco at gmail.com  Tue Aug 23 09:33:04 2011
From: garethcoco at gmail.com (Gareth Coco)
Date: Tue, 23 Aug 2011 12:33:04 -0400
Subject: [Freeassociation-devel] Testing on Windows
In-Reply-To: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
References: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
Message-ID: <CAKfEgi7U+FSX01b6p598mJiyExJ9QopdEKRi+XcvUHHXE4z_MQ@mail.gmail.com>

On Tue, Aug 23, 2011 at 12:15 PM, Gareth Coco <garethcoco at gmail.com> wrote:
> To get around this I had to add the following:
>
> #include <stddef.h> /* For ptrdiff_h */
>
> to both:
>
> src/libicalvcal/libicalvcal.c

More correctly that would be:

src/libicalvcal/icalvcal.c



From garethcoco at gmail.com  Tue Aug 23 11:12:50 2011
From: garethcoco at gmail.com (Gareth Coco)
Date: Tue, 23 Aug 2011 14:12:50 -0400
Subject: [Freeassociation-devel] Testing on Windows
In-Reply-To: <CAKfEgi7U+FSX01b6p598mJiyExJ9QopdEKRi+XcvUHHXE4z_MQ@mail.gmail.com>
References: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
	<CAKfEgi7U+FSX01b6p598mJiyExJ9QopdEKRi+XcvUHHXE4z_MQ@mail.gmail.com>
Message-ID: <CAKfEgi4hrTyrUYptxU5AS5roSYf-wbWv=0fmXB3av5mFYndp=A@mail.gmail.com>

You also need to change in:

src/test/regression.c

line 53

#include <Windows.h>
to
#include <windows.h>

One thing I noticed is that you seem to make a libical.pc but the
install doesn't seem to install this into $prefix/lib/pkgconfig/

The libical.pc does not include a link to -lpthread if it is used.



From winter at kde.org  Tue Aug 23 11:30:44 2011
From: winter at kde.org (Allen Winter)
Date: Tue, 23 Aug 2011 14:30:44 -0400
Subject: [Freeassociation-devel] [PATCH] Re: Crash with attachment on
	libical 0.46
In-Reply-To: <1313997764.7379.1.camel@localhost>
References: <1313559562.14299.7.camel@localhost>
	<201108201307.22668.winter@kde.org>
	<1313997764.7379.1.camel@localhost>
Message-ID: <201108231430.44801.winter@kde.org>


Ok, I committed it.
Will be in the next release.

On Monday, August 22, 2011 03:22:42 am Milan Crha wrote:
> On Sat, 2011-08-20 at 13:07 -0400, Allen Winter wrote:
> > I looked at this, and the problem stems from the fact that we currently
> > don't support the URI type for attachments as specified like this:
> > 
> > ATTACH;TYPE=URI:http://whatever
> > 
> > So attached is a little patch against icalparser.c that might fix this.
> > Please review the patch.
> 
> 	Hi,
> thanks for a quick reply. The patch works fine here, the URI is read and
> the application doesn't crash anymore.
> 	Thanks and bye,
> 	Milan
> 
> 




From winter at kde.org  Tue Aug 23 11:56:18 2011
From: winter at kde.org (Allen Winter)
Date: Tue, 23 Aug 2011 14:56:18 -0400
Subject: [Freeassociation-devel] TODOs before 0.47
Message-ID: <201108231456.18948.winter@kde.org>

Here is my checklist for what I want to get done before the next release.
Feel free to help out.
-Allen

TODO
---------
* some regression tests are failing even though the percentage of success looks good
  look closely at the output (grep on regression.c)

* Bugs-3385364: problem with escaping commas handling multiple categories

* Bugs-3382301: Do not escape double quote character " to \" in iCalendar output (probably fixed by Patches-2932295)

* Bugs-3287603: Memory leak in icaltimezone_set_component

* Patches-3392186: More lenient parsing of duration strings (patch is ok, but a causes a regression failure which needs to be fixed)

* Patches-3392709: Don't replace empty properties with X-LIC-ERROR

* Regression test for Tzfile stuff (test_convenience)?

* Patches-3032973: Patch for building libical on windows with MinGW

* Patches-2932295: Dropping invalid characters from parameters

* Patches-2417984: libical cannot show UTF-8 strings with icalparser_add_line()

* Bugs-2561615: Byteswap fix for icaltz-util.c

* make sure build works and regression test passes for Windows (mingw and msvc)

* make sure build works and regression test passes for Mac.

* merge back fixes from the windows-test branch

DONE
--------
* <D> Crash with attachment on libical 0.46 (My patch for ATTACH;TYPE=URL:)



From room_libical at uncensored.citadel.org  Tue Aug 23 12:49:11 2011
From: room_libical at uncensored.citadel.org (Wilfried Goesgens)
Date: Tue, 23 Aug 2011 15:49:11 -0400
Subject: [Freeassociation-devel] TODOs before 0.47
References: <201108231456.18948.winter@kde.org>
Message-ID: <4E540437-002E02D4@uncensored.citadel.org>

An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20110823/f7f24b39/attachment.html>

From patrick.ohly at gmx.de  Wed Aug 24 02:33:06 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Wed, 24 Aug 2011 11:33:06 +0200
Subject: [Freeassociation-devel] TODOs before 0.47
In-Reply-To: <201108231456.18948.winter@kde.org>
References: <201108231456.18948.winter@kde.org>
Message-ID: <1314178386.3425.82.camel@pohly-mobl1.ikn.intel.com>

On Di, 2011-08-23 at 14:56 -0400, Allen Winter wrote:
> TODO
> ---------
> * some regression tests are failing even though the percentage of success looks good
>   look closely at the output (grep on regression.c)

The system time zone test program fails for some zones. At least at some
point in the past it worked 100% (according to
https://bugzilla.gnome.org/show_bug.cgi?id=548268#c17). I'll have a look
at these failures.

> * Bugs-3287603: Memory leak in icaltimezone_set_component

I also see some leaks in my nightly testing. Will have a look.

What about the TZID lookup regression? Please add that to the TODO list.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From winter at kde.org  Wed Aug 24 03:44:16 2011
From: winter at kde.org (Allen Winter)
Date: Wed, 24 Aug 2011 06:44:16 -0400
Subject: [Freeassociation-devel] TODOs before 0.47
In-Reply-To: <1314178386.3425.82.camel@pohly-mobl1.ikn.intel.com>
References: <201108231456.18948.winter@kde.org>
	<1314178386.3425.82.camel@pohly-mobl1.ikn.intel.com>
Message-ID: <201108240644.16632.winter@kde.org>

On Wednesday 24 August 2011 5:33:06 AM Patrick Ohly wrote:
> On Di, 2011-08-23 at 14:56 -0400, Allen Winter wrote:
> > TODO
> > ---------
> > * some regression tests are failing even though the percentage of success looks good
> >   look closely at the output (grep on regression.c)
> 
> The system time zone test program fails for some zones. At least at some
> point in the past it worked 100% (according to
> https://bugzilla.gnome.org/show_bug.cgi?id=548268#c17). I'll have a look
> at these failures.
> 
> > * Bugs-3287603: Memory leak in icaltimezone_set_component
> 
> I also see some leaks in my nightly testing. Will have a look.
> 
Great, thanks for all your help.

> What about the TZID lookup regression? Please add that to the TODO list.
> 
It's there.  I called it "Regression test for Tzfile stuff (test_convenience)"



From patrick.ohly at gmx.de  Wed Aug 24 04:38:12 2011
From: patrick.ohly at gmx.de (Patrick Ohly)
Date: Wed, 24 Aug 2011 13:38:12 +0200
Subject: [Freeassociation-devel] TODOs before 0.47
In-Reply-To: <201108240644.16632.winter@kde.org>
References: <201108231456.18948.winter@kde.org>
	<1314178386.3425.82.camel@pohly-mobl1.ikn.intel.com>
	<201108240644.16632.winter@kde.org>
Message-ID: <1314185892.3425.88.camel@pohly-mobl1.ikn.intel.com>

On Mi, 2011-08-24 at 06:44 -0400, Allen Winter wrote:
> On Wednesday 24 August 2011 5:33:06 AM Patrick Ohly wrote:
> > What about the TZID lookup regression? Please add that to the TODO list.
> > 
> It's there.  I called it "Regression test for Tzfile stuff (test_convenience)"

I didn't recognize that. The TODO item name is a bit misleading: the
problem is not in the test, it is in libical itself.

-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/





From winter at kde.org  Mon Aug 29 13:18:25 2011
From: winter at kde.org (Allen Winter)
Date: Mon, 29 Aug 2011 16:18:25 -0400
Subject: [Freeassociation-devel] Testing on Windows
In-Reply-To: <CAKfEgi4hrTyrUYptxU5AS5roSYf-wbWv=0fmXB3av5mFYndp=A@mail.gmail.com>
References: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
	<CAKfEgi7U+FSX01b6p598mJiyExJ9QopdEKRi+XcvUHHXE4z_MQ@mail.gmail.com>
	<CAKfEgi4hrTyrUYptxU5AS5roSYf-wbWv=0fmXB3av5mFYndp=A@mail.gmail.com>
Message-ID: <201108291618.25111.winter@kde.org>

Gareth,

Thanks for the feedback.
I believe all your issues have been fixed now in the windows-test branch
with revisions r1094, 1095 and 1096.

please test these fixes.

Regards,
Allen

On Tuesday, August 23, 2011 02:12:50 pm Gareth Coco wrote:
> You also need to change in:
>
> src/test/regression.c
>
> line 53
>
> #include <Windows.h>
> to
> #include <windows.h>
>
> One thing I noticed is that you seem to make a libical.pc but the
> install doesn't seem to install this into $prefix/lib/pkgconfig/
>
> The libical.pc does not include a link to -lpthread if it is used.
>
> ---------------------------------------------------------------------------
>--- Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> user administration capabilities and model configuration. Take
> the hassle out of deploying and managing Subversion and the
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel




From winter at kde.org  Tue Aug 30 07:45:52 2011
From: winter at kde.org (Allen Winter)
Date: Tue, 30 Aug 2011 10:45:52 -0400
Subject: [Freeassociation-devel] Testing on Windows
In-Reply-To: <CAKfEgi4aQccgkNVbZbt4YT-u=U1OTiKAaPrGHmUYrSnvcGGxDg@mail.gmail.com>
References: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
	<201108291618.25111.winter@kde.org>
	<CAKfEgi4aQccgkNVbZbt4YT-u=U1OTiKAaPrGHmUYrSnvcGGxDg@mail.gmail.com>
Message-ID: <201108301045.52401.winter@kde.org>

Gareth,

Try passing -DSTATIC_LIBRARY=true to the cmake command.
Let me know if this works as desired.

I need to add this to the documentation.


On Monday, August 29, 2011 04:48:14 pm Gareth Coco wrote:
> Hi Allen,
>
> Builds fine under the cross compiler I use now.
>
> Is there an easy way when running cmake to disable the shared build
> (other than commenting out info in the CMakeLists.txt file)?
>
> I don't need shared for what I want to use it for.
>
> Thanks
>
> Gareth
>
> On Mon, Aug 29, 2011 at 4:18 PM, Allen Winter <winter at kde.org> wrote:
> > Gareth,
> >
> > Thanks for the feedback.
> > I believe all your issues have been fixed now in the windows-test branch
> > with revisions r1094, 1095 and 1096.
> >
> > please test these fixes.
> >
> > Regards,
> > Allen
> >
> > On Tuesday, August 23, 2011 02:12:50 pm Gareth Coco wrote:
> >> You also need to change in:
> >>
> >> src/test/regression.c
> >>
> >> line 53
> >>
> >> #include <Windows.h>
> >> to
> >> #include <windows.h>
> >>
> >> One thing I noticed is that you seem to make a libical.pc but the
> >> install doesn't seem to install this into $prefix/lib/pkgconfig/
> >>
> >> The libical.pc does not include a link to -lpthread if it is used.
> >>
> >> ------------------------------------------------------------------------
> >>--- --- Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
> >> user administration capabilities and model configuration. Take
> >> the hassle out of deploying and managing Subversion and the
> >> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
> >> _______________________________________________
> >> Freeassociation-devel mailing list
> >> Freeassociation-devel at lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel




From garethcoco at gmail.com  Tue Aug 30 07:55:56 2011
From: garethcoco at gmail.com (Gareth Coco)
Date: Tue, 30 Aug 2011 10:55:56 -0400
Subject: [Freeassociation-devel] Testing on Windows
In-Reply-To: <201108301045.52401.winter@kde.org>
References: <CAKfEgi6-NnA7v+_ejEN2ocP9=bqcUXWESa1MEGksxaTWwMqOhA@mail.gmail.com>
	<201108291618.25111.winter@kde.org>
	<CAKfEgi4aQccgkNVbZbt4YT-u=U1OTiKAaPrGHmUYrSnvcGGxDg@mail.gmail.com>
	<201108301045.52401.winter@kde.org>
Message-ID: <CAKfEgi4KqYNEEQZXQid28ssHbj_D223RX_w0hVtbM4auwYmtqA@mail.gmail.com>

Hi Allen,

This does indeed cause a static only build.

Thanks for that.

Gareth

On Tue, Aug 30, 2011 at 10:45 AM, Allen Winter <winter at kde.org> wrote:

> Try passing -DSTATIC_LIBRARY=true to the cmake command.
> Let me know if this works as desired.
>
> I need to add this to the documentation.



