[Freeassociation-devel] r965 through r968 are Patrick's patches

Suman Manjunath manjunath.suman at gmail.com
Wed Sep 16 00:41:27 PDT 2009


On Wed, 2009-09-16 at 02:52 -0400, Suman Manjunath wrote:
> Hi.. 
> 
> I tried a local build after generating a tarball from SVN. There were a
> couple of build failures. Attached patch fixes it. 
> 
> 1) We don't build the python bindings for some reason. Yet, we generate
> the makefiles for the sub-directory. We don't compile the sub-directory
> regardless of the user preference of --enable-python ( => the python
> subdir is not bundled in the tarball). So, when someone tries to compile
> with a tarball, it goes boom!
> [Please note: even with the patch attached, --enable-python will _not_
> build the python bindings. Not sure what the problem was before, I chose
> to leave it as it was. (in fact, I did try to fix this as well and
> succeeded with some hacks, in doing so, --enable-python needed an
> --enable-static]
> 
> 2) Similar issue with the zoneinfo sub-directory. Respect the user
> preference of --without-builtintz

A second patch for another build failure due to a critical compiler
warning. (this one was easy).

> HTH
> 
> -Suman
> 
> On Tue, 2009-09-15 at 22:42 -0400, IGnatius T Foobar wrote:
> > 
> >  r965 through r968 represent the application of Patrick's four patches.  
> > Testing can now commence, followed by bumping the version number and 
> > getting ready for a release.  
> >    
> >   -- Art  
> >   
> > 
> > ------------------------------------------------------------------------------
> > Come build with us! The BlackBerry® Developer Conference in SF, CA
> > is the only developer event you need to attend this year. Jumpstart your
> > developing skills, take BlackBerry mobile applications to market and stay 
> > ahead of the curve. Join us from November 9-12, 2009. Register now!
> > http://p.sf.net/sfu/devconf
> > _______________________________________________
> > Freeassociation-devel mailing list
> > Freeassociation-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/freeassociation-devel
-------------- next part --------------
commit a8a87bbec6fa70d611dd2d3fafa3d792ed6d96eb
Author: Suman Manjunath <msuman at gnome.org>
Date:   Wed Sep 16 03:36:30 2009 -0400

    Return NULL time if end-of-function is reached.
    
    Author:    Suman Manjunath <msuman at gnome.org>
    
    	modified:   src/libical/icalcomponent.c

diff --git a/libical/src/libical/icalcomponent.c b/libical/src/libical/icalcomponent.c
index b32ad3b..bc1031c 100644
--- a/libical/src/libical/icalcomponent.c
+++ b/libical/src/libical/icalcomponent.c
@@ -2603,6 +2603,7 @@ struct icaltimetype icalcomponent_get_due(icalcomponent* comp)
 
     }
 
+    return icaltime_null_time();
 }
 
 /** @brief Set the due date of a VTODO task.


More information about the libical-devel mailing list