[patch V2 33/36] net: libertas: Use netif_rx_any_context()

James Cameron quozl at laptop.org
Tue Sep 29 17:53:03 EDT 2020


On Tue, Sep 29, 2020 at 10:25:42PM +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> 
> The usage of in_interrupt() in non-core code is phased out. Ideally the
> information of the calling context should be passed by the callers or the
> functions be split as appropriate.
> 
> libertas uses in_interupt() to select the netif_rx*() variant which matches
> the calling context. The attempt to consolidate the code by passing an
> arguemnt or by distangling it failed due lack of knowledge about this
> driver and because the call chains are hard to follow.
> 
> As a stop gap use netif_rx_any_context() which invokes the correct code
> path depending on context and confines the in_interrupt() usage to core
> code.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
> Acked-by: Kalle Valo <kvalo at codeaurora.org>

Reviewed-by: James Cameron <quozl at laptop.org>

-- 
James Cameron
http://quozl.netrek.org/



More information about the libertas-dev mailing list