From baolex.ni at intel.com Tue Aug 2 04:46:08 2016 From: baolex.ni at intel.com (Baole Ni) Date: Tue, 2 Aug 2016 19:46:08 +0800 Subject: [PATCH 0785/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802114608.2081-1-baolex.ni@intel.com> I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/wireless/marvell/libertas/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c index 8541cbe..b4fa7bd 100644 --- a/drivers/net/wireless/marvell/libertas/main.c +++ b/drivers/net/wireless/marvell/libertas/main.c @@ -36,11 +36,11 @@ const char lbs_driver_version[] = "COMM-USB8388-" DRIVER_RELEASE_VERSION /* Module parameters */ unsigned int lbs_debug; EXPORT_SYMBOL_GPL(lbs_debug); -module_param_named(libertas_debug, lbs_debug, int, 0644); +module_param_named(libertas_debug, lbs_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); unsigned int lbs_disablemesh; EXPORT_SYMBOL_GPL(lbs_disablemesh); -module_param_named(libertas_disablemesh, lbs_disablemesh, int, 0644); +module_param_named(libertas_disablemesh, lbs_disablemesh, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* -- 2.9.2 From baolex.ni at intel.com Tue Aug 2 04:46:18 2016 From: baolex.ni at intel.com (Baole Ni) Date: Tue, 2 Aug 2016 19:46:18 +0800 Subject: [PATCH 0786/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802114618.2152-1-baolex.ni@intel.com> I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/net/wireless/marvell/libertas/mesh.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c index d0c881d..ae4f0a5 100644 --- a/drivers/net/wireless/marvell/libertas/mesh.c +++ b/drivers/net/wireless/marvell/libertas/mesh.c @@ -297,19 +297,19 @@ static ssize_t lbs_mesh_set(struct device *dev, * lbs_mesh attribute to be exported per ethX interface * through sysfs (/sys/class/net/ethX/lbs_mesh) */ -static DEVICE_ATTR(lbs_mesh, 0644, lbs_mesh_get, lbs_mesh_set); +static DEVICE_ATTR(lbs_mesh, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_mesh_get, lbs_mesh_set); /* * anycast_mask attribute to be exported per mshX interface * through sysfs (/sys/class/net/mshX/anycast_mask) */ -static DEVICE_ATTR(anycast_mask, 0644, lbs_anycast_get, lbs_anycast_set); +static DEVICE_ATTR(anycast_mask, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_anycast_get, lbs_anycast_set); /* * prb_rsp_limit attribute to be exported per mshX interface * through sysfs (/sys/class/net/mshX/prb_rsp_limit) */ -static DEVICE_ATTR(prb_rsp_limit, 0644, lbs_prb_rsp_limit_get, +static DEVICE_ATTR(prb_rsp_limit, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_prb_rsp_limit_get, lbs_prb_rsp_limit_set); static struct attribute *lbs_mesh_sysfs_entries[] = { @@ -764,13 +764,13 @@ static ssize_t capability_set(struct device *dev, struct device_attribute *attr, } -static DEVICE_ATTR(bootflag, 0644, bootflag_get, bootflag_set); -static DEVICE_ATTR(boottime, 0644, boottime_get, boottime_set); -static DEVICE_ATTR(channel, 0644, channel_get, channel_set); -static DEVICE_ATTR(mesh_id, 0644, mesh_id_get, mesh_id_set); -static DEVICE_ATTR(protocol_id, 0644, protocol_id_get, protocol_id_set); -static DEVICE_ATTR(metric_id, 0644, metric_id_get, metric_id_set); -static DEVICE_ATTR(capability, 0644, capability_get, capability_set); +static DEVICE_ATTR(bootflag, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, bootflag_get, bootflag_set); +static DEVICE_ATTR(boottime, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, boottime_get, boottime_set); +static DEVICE_ATTR(channel, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, channel_get, channel_set); +static DEVICE_ATTR(mesh_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, mesh_id_get, mesh_id_set); +static DEVICE_ATTR(protocol_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, protocol_id_get, protocol_id_set); +static DEVICE_ATTR(metric_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, metric_id_get, metric_id_set); +static DEVICE_ATTR(capability, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, capability_get, capability_set); static struct attribute *boot_opts_attrs[] = { &dev_attr_bootflag.attr, -- 2.9.2 From shankerwangmiao at gmail.com Tue Aug 2 08:50:02 2016 From: shankerwangmiao at gmail.com (Shanker Wang) Date: Tue, 2 Aug 2016 23:50:02 +0800 Subject: [PATCH 0786/1285] Replace numeric parameter like 0444 with macro In-Reply-To: <20160802114618.2152-1-baolex.ni@intel.com> References: <20160802114618.2152-1-baolex.ni@intel.com> Message-ID: I don?t think macros is clearer, and the meaning of those so called ?magic numbers? like 0644 is clear enough. People are used to that. As a result, it is not meaningful to replace them with macro. > ? 2016?8?2??19:46?Baole Ni ??? > > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/net/wireless/marvell/libertas/mesh.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c > index d0c881d..ae4f0a5 100644 > --- a/drivers/net/wireless/marvell/libertas/mesh.c > +++ b/drivers/net/wireless/marvell/libertas/mesh.c > @@ -297,19 +297,19 @@ static ssize_t lbs_mesh_set(struct device *dev, > * lbs_mesh attribute to be exported per ethX interface > * through sysfs (/sys/class/net/ethX/lbs_mesh) > */ > -static DEVICE_ATTR(lbs_mesh, 0644, lbs_mesh_get, lbs_mesh_set); > +static DEVICE_ATTR(lbs_mesh, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_mesh_get, lbs_mesh_set); > > /* > * anycast_mask attribute to be exported per mshX interface > * through sysfs (/sys/class/net/mshX/anycast_mask) > */ > -static DEVICE_ATTR(anycast_mask, 0644, lbs_anycast_get, lbs_anycast_set); > +static DEVICE_ATTR(anycast_mask, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_anycast_get, lbs_anycast_set); > > /* > * prb_rsp_limit attribute to be exported per mshX interface > * through sysfs (/sys/class/net/mshX/prb_rsp_limit) > */ > -static DEVICE_ATTR(prb_rsp_limit, 0644, lbs_prb_rsp_limit_get, > +static DEVICE_ATTR(prb_rsp_limit, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, lbs_prb_rsp_limit_get, > lbs_prb_rsp_limit_set); > > static struct attribute *lbs_mesh_sysfs_entries[] = { > @@ -764,13 +764,13 @@ static ssize_t capability_set(struct device *dev, struct device_attribute *attr, > } > > > -static DEVICE_ATTR(bootflag, 0644, bootflag_get, bootflag_set); > -static DEVICE_ATTR(boottime, 0644, boottime_get, boottime_set); > -static DEVICE_ATTR(channel, 0644, channel_get, channel_set); > -static DEVICE_ATTR(mesh_id, 0644, mesh_id_get, mesh_id_set); > -static DEVICE_ATTR(protocol_id, 0644, protocol_id_get, protocol_id_set); > -static DEVICE_ATTR(metric_id, 0644, metric_id_get, metric_id_set); > -static DEVICE_ATTR(capability, 0644, capability_get, capability_set); > +static DEVICE_ATTR(bootflag, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, bootflag_get, bootflag_set); > +static DEVICE_ATTR(boottime, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, boottime_get, boottime_set); > +static DEVICE_ATTR(channel, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, channel_get, channel_set); > +static DEVICE_ATTR(mesh_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, mesh_id_get, mesh_id_set); > +static DEVICE_ATTR(protocol_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, protocol_id_get, protocol_id_set); > +static DEVICE_ATTR(metric_id, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, metric_id_get, metric_id_set); > +static DEVICE_ATTR(capability, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, capability_get, capability_set); > > static struct attribute *boot_opts_attrs[] = { > &dev_attr_bootflag.attr, > -- > 2.9.2 > From e.contactsuncity at mymail-inbox.com Fri Aug 26 21:11:33 2016 From: e.contactsuncity at mymail-inbox.com (Shiny ZelDrian) Date: Sat, 27 Aug 2016 06:11:33 +0200 Subject: [PR] Aug 26 2016 "PFYU HLP" Message-ID: Hi Friend. May I first and foremost appeal to your understanding if you find my email intrusive. It is out of desperation that I have chosen to contact you. My name is ADRIANA MARIA ACCIOLY ZELADA. I am a native of Brazil. I do not know you neither have I met you before. I simply found your contact information from Brazilian Local Data Base Archives. Before I go further with my intention of contacting you, The following information is necessary for my identification. I was married to JORGE LUIZ ZELADA until July 2 2015, when he was arrested by the Rio Special Police on accusation of corruption. My husband arrest was nothing but a political witch hunt because of his criticism of the current deposed president of Brazil, DILMA ROUSSEFF. My husband was the International Director/Chief Executive of Petrobras between 2008 to 2012.You can read more about his situation on the BBC website: http://www.bbc.com/news/world-latin-america-35467529 I am contacting you privately and secrely to seek your assistance in helping us receive, accommodate and possibly invest the sum of 15.5 M US which my husband managed to safely hold in the shore of Europe under my name as the Trustee. The information of the existence of this sum was secretly exposed to me by my husband lawyer. Please I humbly seek your assistance to help us because life is difficult for us at the moment. After my husbands arrest, the Justice Ministry of Rio De Janeiro ordered for confiscation of our properties, homes and seizure of my bank account. Our traveling documents( Passports) was also taken away from us. I am ready to work with you once I heard from you. Thank you ADRIANA MARIA ACCIOLY ZELADA August 17 2016 Rio De Janerio Brazil.