[PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL

Michał Mirosław mirqus at gmail.com
Fri Feb 24 12:59:04 EST 2012

2012/2/24 Danny Kukawka <danny.kukawka at bisect.de>:
> Second Part of series patches to unifiy the return value of
> .ndo_set_mac_address if the given address isn't valid.
> These changes check if a given (MAC) address is valid in
> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
> as eth_mac_addr() already does if is_valid_ether_addr() fails.

Why not just fix dev_set_mac_address() and make do_setlink() use that?
Checks are specific to address family, not device model I assume.

Best Regards,
Michał Mirosław

More information about the libertas-dev mailing list