[PATCH] wireless: libertas: fix unaligned accesses

Mike Frysinger vapier at gentoo.org
Tue May 26 12:54:12 EDT 2009


On Tuesday 26 May 2009 06:56:01 Sebastian Andrzej Siewior wrote:
> * Mike Frysinger | 2009-05-26 06:26:22 [-0400]:
> >--- a/drivers/net/wireless/libertas/cmdresp.c
> >+++ b/drivers/net/wireless/libertas/cmdresp.c
> >@@ -154,11 +154,11 @@ static int lbs_ret_802_11_rssi(struct lbs_private
> >-	priv->SNR[TYPE_BEACON][TYPE_NOAVG] = le16_to_cpu(rssirsp->SNR);
> >-	priv->NF[TYPE_BEACON][TYPE_NOAVG] = le16_to_cpu(rssirsp->noisefloor);
> >+	priv->SNR[TYPE_BEACON][TYPE_NOAVG] =
> > get_unaligned_le16(&(rssirsp->SNR)); +	priv->NF[TYPE_BEACON][TYPE_NOAVG]
> > = get_unaligned_le16(&(rssirsp->noisefloor));
>
> are the extra () really required?

probably not

> >diff --git a/drivers/net/wireless/libertas/scan.c
> > b/drivers/net/wireless/libertas/scan.c index 8124db3..cc5c3ff 100644
> >--- a/drivers/net/wireless/libertas/scan.c
> >+++ b/drivers/net/wireless/libertas/scan.c
> >@@ -1130,7 +1130,8 @@ static int lbs_ret_80211_scan(struct lbs_private
> >-	bytesleft = le16_to_cpu(scanresp->bssdescriptsize);
> >+	/*bytesleft = le16_to_cpu(scanresp->bssdescriptsize);*/
>
> that line can go, can't it?

sorry, i thought i had deleted it when cleaning up the patch

i'll send out a new one of course
-mike



More information about the libertas-dev mailing list