[PATCH v2] libertas: fix IEEE PS mode in GSPI driver

Dan Williams dcbw at redhat.com
Tue Jun 16 15:40:54 EDT 2009


On Fri, 2009-06-12 at 12:45 -0700, Andrey Yurovsky wrote:
> The card firmware does not set the Command Download Ready interrupt bit
> when IEEE PS mode is enabled, preventing the driver from sending
> commands (such as the command to exit IEEE PS mode) since there is no
> indication that the card is ready to accept commands.
> 
> This patch works around the problem by using the the TX Download Ready
> bit in place of the Command Download Ready Bit while in IEEE PS mode.
> TX Download Ready is set in IEEE PS mode.
> 
> Signed-off-by: Andrey Yurovsky <andrey at cozybit.com>
> Signed-off-by: Javier Cardona <javier at cozybit.com>

Acked-by: Dan Williams <dcbw at redhat.com>

> ---
>  drivers/net/wireless/libertas/if_spi.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
> index f8c2898..dc2a1f6 100644
> --- a/drivers/net/wireless/libertas/if_spi.c
> +++ b/drivers/net/wireless/libertas/if_spi.c
> @@ -875,7 +875,12 @@ static int lbs_spi_thread(void *data)
>  			err = if_spi_c2h_data(card);
>  			if (err)
>  				goto err;
> -		if (hiStatus & IF_SPI_HIST_CMD_DOWNLOAD_RDY) {
> +
> +		/* workaround: in PS mode, the card does not set the Command
> +		 * Download Ready bit, but it sets TX Download Ready. */
> +		if (hiStatus & IF_SPI_HIST_CMD_DOWNLOAD_RDY ||
> +		   (card->priv->psstate != PS_STATE_FULL_POWER &&
> +		    (hiStatus & IF_SPI_HIST_TX_DOWNLOAD_RDY))) {
>  			/* This means two things. First of all,
>  			 * if there was a previous command sent, the card has
>  			 * successfully received it.




More information about the libertas-dev mailing list