[PATCH] libertas: fix power save issue in libertas_sdio module

Bing Zhao bzhao at marvell.com
Wed Feb 11 14:26:57 EST 2009


Sven,

Yes. This is intentional for SD8385.
 
Bing

-----Original Message-----
From: Sven Neumann [mailto:s.neumann at phase-zero.de] 
Sent: Wednesday, February 11, 2009 1:48 AM
To: Bing Zhao
Cc: libertas-dev at lists.infradead.org
Subject: Re: [PATCH] libertas: fix power save issue in libertas_sdio
module

Hi,

On Tue, 2009-02-10 at 20:57 -0800, Bing Zhao wrote:

> Subject: [PATCH] libertas: fix power save issue in libertas_sdio
module
> 
> The problem: "iwconfig ethX power on" returns error
> 
> The cause: "ps_supported" flag was never set for SD8385/8686
> 
> The fix: check firmware capabilities returned by GET_HW_SPEC command.
> Set "ps_supported" to 1 if FW_CAPINFO_PS bit is on. This fix applies
> to SDIO interface only.

Your patch also introduces a bitshift in if_sdio_handle_event() in the
code branch for (card->model == 0x04). Is this intentional?


Sven





More information about the libertas-dev mailing list