[PATCH] libertas: Improvements on automatic tx power control via SIOCSIWTXPOW.

Anna Neal anna at cozybit.com
Thu Sep 11 14:56:47 EDT 2008


On Thu, Sep 11, 2008 at 11:37 AM, Johannes Berg
<johannes at sipsolutions.net> wrote:
> On Thu, 2008-09-11 at 11:17 -0700, Anna Neal wrote:
>
>> +/**
>> + * @brief Configures the transmission power control functionality.
>> + *
>> + * @param priv               A pointer to struct lbs_private structure
>> + * @param enable     Transmission power control enable
>> + * @param p0         Power level when link quality is good (dBm).
>> + * @param p1         Power level when link quality is fair (dBm).
>> + * @param p2         Power level when link quality is poor (dBm).
>> + * @param usesnr     Use Signal to Noise Ratio in TPC
>> + *
>> + * @return 0 on success
>
> What doc tools are you using? This isn't kernel-doc notation, is it?

Thanks for the feedback,

I was just trying to be consistent with the rest of the file. I am not
currently using kernel-doc.

Maybe its worth it, in a subsequent patch, to convert the whole file
to kernel-doc notation?

Any volunteers?

Anna

>
> [not that I think that should prevent the patch from going in, at this
> point, since I don't think the file is read by kernel-doc anyway]
>
> johannes
>



More information about the libertas-dev mailing list