[PATCH] libertas: reduce command retry time

[David Woodhouse]

On Thu, 2008-05-01 at 23:30 +0200, Holger Schurig wrote:
> > I think I've seen it take a few of the 5-second timeouts.
> 
> Do you you know for which commands this has been?
> 
> 
> > I wouldn't like to decrease the maximum so drastically.
> 
> How far would you go?
> 
> Or: maybe there is another way to make "pccardctl eject"
> work reasonably fast in the case of a retrying command. Any
> idea?

Does it set priv->surpriseremoved? We should honour that.

> > Also, that del_timer_sync() happens in the module unload path, doesn't
> > it? I'd want to see why you think it isn't needed.
> 
> I thought that del_timer_sync() waits until the timer has been
> executed? If yes, then that's the wrong thing here, I want to unload
> quickly. Makes no sense to wait till the command_timer finally fires
> and re-sends the failed command.

No, it just waits until the timer has been properly removed. If the
timer was set for some time in the future, it doesn't wait for it to
happen naturally.

-- 
dwmw2