[PATCH] libertas: fix use-before-check violation

Dan Williams dcbw at redhat.com
Wed Apr 30 16:21:46 EDT 2008


On Tue, 2008-04-29 at 10:07 +0200, Holger Schurig wrote:
> [PATCH] fix use-before-check violation
> 
> According to Coverity (kudo's to Adrian Bunk), we had one use-before-check
> bug in libe libertas driver. This patch fixes this issue.
> 
> Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>

Acked-by: Dan Williams <dcbw at redhat.com>

> Index: wireless-testing/drivers/net/wireless/libertas/scan.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/scan.c	2008-04-29 09:07:19.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/scan.c	2008-04-29 09:07:39.000000000 +0200
> @@ -298,7 +298,8 @@ static int lbs_do_scan(struct lbs_privat
>  	uint8_t *tlv;	/* pointer into our current, growing TLV storage area */
>  
>  	lbs_deb_enter_args(LBS_DEB_SCAN, "bsstype %d, chanlist[].chan %d, chan_count %d",
> -			   bsstype, chan_list[0].channumber, chan_count);
> +		bsstype, chan_list ? chan_list[0].channumber : -1,
> +		chan_count);
>  
>  	/* create the fixed part for scan command */
>  	scan_cmd = kzalloc(MAX_SCAN_CFG_ALLOC, GFP_KERNEL);




More information about the libertas-dev mailing list