[PATCH] MESH ALWAYS ON

[Brajesh Dave]

Hi Holger,

Thanks for pointing out that mistake. I have made that correction and
sending the patch again in my next email.

Regards,
Brajesh

-----Original Message-----
From: libertas-dev-bounces at lists.infradead.org
[mailto:libertas-dev-bounces at lists.infradead.org] On Behalf Of Holger
Schurig
Sent: Thursday, October 18, 2007 12:42 PM
To: libertas-dev at lists.infradead.org
Subject: Re: [PATCH] MESH ALWAYS ON

Hi Dave !

I haven't looked at your patch per-se (as I mostly use a CF card with
a mesh-unaware firmware), but here's a comment on the patch format:

> -		    (adapter->connect_status == LIBERTAS_CONNECTED)) {
> +		    ((adapter->connect_status == LIBERTAS_CONNECTED) ||
> +		    (adapter->mesh_connect_status ==
> LIBERTAS_CONNECTED)) ) {

You need to turn word-wrap off in your E-Mail-Client. Because your
e-mail client wrapped the "LIBERTAS_CONNECTED)) ) {" to the next line.

This happened several times.


This makes it quite impossible to use your e-mail to feed "patch",
"git" or "quilt" with it.

For example, in KMail it's in "Options" -> "Wordwrap" while writing
a mail.




Once question, thought. For example, in:

@@ -1080,7 +1097,8 @@ static int wlan_get_rate(struct net_device *dev,
struct iw_request_info *info,
 
        lbs_deb_enter(LBS_DEB_WEXT);
 
-       if (adapter->connect_status == LIBERTAS_CONNECTED) {
+       if( (adapter->connect_status == LIBERTAS_CONNECTED) || 
+           (adapter->mesh_connect_status == LIBERTAS_CONNECTED)) {
                vwrq->value = adapter->cur_rate * 500000;
 
                if (adapter->auto_rate)
-- 
1.5.2.4

Does this mean that in the current code, that the get rate wireless
extension ioctl only works if the adapter is connected? With your
patch, it would work if either the adapter (a.k.a. 802.11) or the mesh
is connected?

Wouldn't that return a rate on eth1 (802.11) even when it is down
and not associated to anywhere when msh0 is up?

_______________________________________________
libertas-dev mailing list
libertas-dev at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/libertas-dev