[PATCH, take 2] libertas: fixes for slow hardware

John W. Linville linville at tuxdriver.com
Tue Oct 9 17:18:22 EDT 2007


On Tue, Oct 09, 2007 at 10:41:57AM +0200, Holger Schurig wrote:

> @@ -148,11 +148,11 @@ static int if_cs_poll_while_fw_download(
>  {
>  	int i;
>  
> -	for (i = 0; i < 500; i++) {
> +	for (i = 0; i < 1000; i++) {
>  		u8 val = if_cs_read8(card, addr);
>  		if (val == reg)
>  			return i;
> -		udelay(100);
> +		udelay(500);
>  	}
>  	return -ETIME;
>  }

10x the maximum delay?  Is this really necessary?  How did you
determine this was needed?

If it really is necessary, you need to change the "The host polls
the Card Status register for 50 ms..." comment in if_cs_prog_helper
as well.

John
-- 
John W. Linville
linville at tuxdriver.com



More information about the libertas-dev mailing list