i finally have a git tree :-)

Marcelo Tosatti marcelo at kvack.org
Sat Feb 17 22:36:25 EST 2007


Hi Holger,

On Sat, Feb 17, 2007 at 11:22:08PM +0100, Holger Schurig wrote:
> David Woodhouse was so kind to host a yet-another git tree. I made one 
> with little patches and cleanups that are hopefully not controversial.
>  
> Feel free to cherry-pick from
> git://git.infradead.org/~schurig/libertas-cleanups-2.6.git
> 
> View at
> http://git.infradead.org/?p=users/schurig/libertas-cleanups-2.6.git

commit c67c07404eae47e4e4b9d0b358eb15413cc25d8e
Author: Holger Schurig <schurig at laptop.mn-solutions.de>
Date:   Sat Feb 17 23:32:30 2007 +0100

    libertas: exclude non-used code when PROC_DEBUG is not set

    This reduces usb8xxx.ko by 951 bytes (text) and 256 bytes (data)
    when PROC_DEBUG isn't defined.

    Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>

This looks good, however this hunk:

@@ -61,15 +64,7 @@ static ssize_t libertas_getscantable(str
        char *buf = (char *)addr;

        pos += snprintf(buf+pos, len-pos,
-                       "---------------------------------------");
-       pos += snprintf(buf+pos, len-pos,
-                       "---------------------------------------\n");
-       pos += snprintf(buf+pos, len-pos,
                "# | ch  | ss  |       bssid       |   cap    |    TSF   | Qual | SSID \n");
-       pos += snprintf(buf+pos, len-pos,
-               "---------------------------------------");
-       pos += snprintf(buf+pos, len-pos,
-               "---------------------------------------\n");


Makes no sense to me. Why removing the header from getscantable?




More information about the libertas-dev mailing list