[PATCH] libertas: fix data packet size errors

David Woodhouse dwmw2 at infradead.org
Thu Dec 6 04:50:26 EST 2007


On Thu, 2007-12-06 at 10:15 +0100, Holger Schurig wrote:
> 
> +       /* This is a workaround for a firmware that reports too much
> +        * bytes */
> +       *len -= 8
>         ret = 0;

You might want another semicolon somewhere in there?

And if we're not looking at the length at all, that's bad. We should
probably at _least_ compare it with the size field, to make sure we got
everything that was sent, and that we're not reading off the end of the
buffer.

-- 
dwmw2




More information about the libertas-dev mailing list