[LEDE-DEV] [PATCH 3/5] staging: mt7621-eth: fix return value check in mtk_probe()
Rosen Penev
rosenp at gmail.com
Mon May 14 11:14:23 PDT 2018
From: Wei Yongjun <weiyongjun1 at huawei.com>
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files")
Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
.../linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index d0d88b9..c806e28 100644
--- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1513,7 +1513,7 @@ static int fe_probe(struct platform_device *pdev)
soc->reg_table = fe_reg_table;
fe_base = devm_ioremap_resource(&pdev->dev, res);
- if (!fe_base) {
+ if (IS_ERR(fe_base)) {
err = -EADDRNOTAVAIL;
goto err_out;
}
--
2.7.4
More information about the Lede-dev
mailing list