[LEDE-DEV] [PATCH 1/2] procd: Fix respawn after restart of instance

Pavel Merzlyakov pavel.merzlyakov at gmail.com
Fri Mar 23 04:55:57 PDT 2018


Miss this patch -> "[LEDE-DEV] [PATCH] procd: Restore respawn on
SIGTERM timeout"
(http://lists.infradead.org/pipermail/lede-dev/2017-October/009412.html)
It's try to solve same problem.

Description seems to be misleading (patch also seems to be wrong):
>When SIGTERM times out, procd sends SIGKILL and then restarts the
>process once SIGCHLD has been received. This all works fine, with one
>exception - respawn is not restored when instance_start() is called from
>instance_exit(). The reason is that respawn is always set to false in
>instance_stop(), and the same service_instance struct is used for the
>instance_start()-call.

Because respawn is not restored when instance_start() is called from
instance_update() (not from instance_exit()).
In order to reproduce problem we should call instance_start() before
instance_exit().

PS
If we call instance_stop() it set in->restart to false and
instance_start() will never be called from instance_exit().



More information about the Lede-dev mailing list