[LEDE-DEV] [PATCH] kernel: backport fix undefined abort

[Jonas Gorski]

On 30 January 2018 at 21:04, Andrey Jr. Melnikov <temnota.am at gmail.com> wrote:
> Hauke Mehrtens <hauke at hauke-m.de> wrote:
>
>
>> On 01/30/2018 04:32 PM, Andrey Jr. Melnikov wrote:
>> > Evgeniy Didin <Evgeniy.Didin at synopsys.com> wrote:
>> >
>> >> While building mpi.ko module with stable Linux v4.14.14 an error occured:
>> >>> ERROR: "abort" [lib/mpi/mpi.ko] undefined!
>> >> In upstream Linux 4.15 this issue is fixed:
>> >> Commit 7c2c11b208be ("arch: define weak abort()")
>> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7c2c11b208be09c156573fc0076b7b3646e05219
>> >
>> >> Commit dc8635b78cd8 ("kernel/exit.c: export abort() to modules")
>> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dc8635b78cd8669c37e230058d18c33af7451ab1
>> >
>> >> So lets add backport patches until these fixes
>> >> are not applied in stable version.
>> >
>> >> Signed-off-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com>
>> >> Cc: Alexey Brodkin <abrodkin at synopsys.com>
>> >> CC: John Crispin <john at phrozen.org>
>> >> CC: Hauke Mehrtens <hauke at hauke-m.de>
>> >
>> > Copy this description into commit comments. After next patch rebase - it lost.
>
>> The patch already contain the full commit message and the hash so it is
>> pretty easy to find where they are from. I think this patch looks good.
>> I still hope that this will go into the 4.14 stable tree and we do not
>> have to maintain this any more.
> Original commit message not explaining WHY and FOR WHAT this patch added in
> openwrt tree.

That's what the commit message of the commit adding these patches is for.

Patches taken from upstream/submitted to upstream need to keep their
original commit message intact.

This is needed to identify the source of the patch.

> When adding new kernel and rebase patches - you and other developers COPY
> patches across new directory and losing history - why this patch landed
> in tree.
> Try understand why 650-pppoe_header_pad.patch here?
> Or 680-NET-skip-GRO-for-foreign-MAC-addresses.patch ?

"git log --follow" is your friend.

# git log --follow target/linux/generic/pending-4.4/650-pppoe_header_pad.patch
...
commit 6517a757ec711fc3354b857e273e2621042f3c7a
Author: Felix Fietkau <nbd at openwrt.org>
Date:   Mon Jun 29 21:54:11 2009 +0000

    pppoe: add extra padding for the header (useful for drivers that
need headroom)

    SVN-Revision: 16628

# git log --follow
target/linux/generic/pending-4.4/680-NET-skip-GRO-for-foreign-MAC-addresses.patch
...
commit b011293d0be54dc724039acb0450dc8a6666ba32
Author: Felix Fietkau <nbd at openwrt.org>
Date:   Wed Mar 18 18:22:41 2015 +0000

    kernel: replace GRO optimization patch with a new one that
supports VLANs/bridges with different MAC addresses

    Signed-off-by: Felix Fietkau <nbd at openwrt.org>

    SVN-Revision: 44877


Regards
Jonas