[LEDE-DEV] [PATCH v1] dnsmasq: backport validation fix in dnssec security fix
Kevin Darbyshire-Bryant
ldir at darbyshire-bryant.me.uk
Sat Jan 20 00:46:28 PST 2018
A DNSSEC validation error was introduced in the fix for CVE-2017-15107
Backport the upstream fix to the fix (a simple typo)
Signed-off-by: Kevin Darbyshire-Bryant <ldir at darbyshire-bryant.me.uk>
---
Guess who found this one! Running chez Kelley for a while as the CVE fixes
were embargoed. About 30 minutes after I sent to upstream I spotted some
odd dnssec behaviour - spoke to Simon... "damn" and bug squished.
package/network/services/dnsmasq/Makefile | 2 +-
package/network/services/dnsmasq/patches/270-dnssec-wildcards.patch | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/network/services/dnsmasq/Makefile b/package/network/services/dnsmasq/Makefile
index 3ef7a317d4..7ba7d56b52 100644
--- a/package/network/services/dnsmasq/Makefile
+++ b/package/network/services/dnsmasq/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=dnsmasq
PKG_VERSION:=2.78
-PKG_RELEASE:=9
+PKG_RELEASE:=10
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=http://thekelleys.org.uk/dnsmasq/
diff --git a/package/network/services/dnsmasq/patches/270-dnssec-wildcards.patch b/package/network/services/dnsmasq/patches/270-dnssec-wildcards.patch
index 029e7ea7af..d13ac2cbad 100644
--- a/package/network/services/dnsmasq/patches/270-dnssec-wildcards.patch
+++ b/package/network/services/dnsmasq/patches/270-dnssec-wildcards.patch
@@ -160,7 +160,7 @@ in a domain which includes a wildcard for NSEC.
+ int type_covered;
+ unsigned char *psav = p1;
+
-+ if (rdlen < 18)
++ if (rdlen1 < 18)
+ return 0; /* bad packet */
+
+ GETSHORT(type_covered, p1);
--
2.14.3 (Apple Git-98)
More information about the Lede-dev
mailing list