[LEDE-DEV] [PATCH 2/4] ipq: Don't force selection of the IPQ4019 firmware.

[Ben Greear]

On 01/19/2018 01:03 PM, Christian Lamparter wrote:
> On Friday, January 19, 2018 9:12:04 PM CET greearb at candelatech.com wrote:
>> From: Ben Greear <greearb at candelatech.com>
>>
>> This will allow us to select the CT IPQ4019 firmware instead if
>> desired.
>>
>> Signed-off-by: Ben Greear <greearb at candelatech.com>
>> ---
>>  package/firmware/ipq-wifi/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/firmware/ipq-wifi/Makefile b/package/firmware/ipq-wifi/Makefile
>> index 519e8c9..6690248 100644
>> --- a/package/firmware/ipq-wifi/Makefile
>> +++ b/package/firmware/ipq-wifi/Makefile
>> @@ -20,7 +20,7 @@ define Package/ipq-wifi-default
>>    SUBMENU:=ath10k IPQ4019 Boarddata
>>    SECTION:=firmware
>>    CATEGORY:=Firmware
>> -  DEPENDS:=@TARGET_ipq806x +ath10k-firmware-qca4019
>> +  DEPENDS:=@TARGET_ipq806x
>>    TITLE:=Custom Board
>>  endef
>>
>
> Wait! I remember talking about this here in the RFC thread:
> <https://www.mail-archive.com/lede-dev@lists.infradead.org/msg09621.html>
> |Hm, this would break the WIFI in the default configuration for the
> |FritzBox 4040 image. Currently it only has a dependency on the
> |ipq-wifi-fritz4040. (So it will end up without a firmware-5.bin)
>
> What gives? Are you trying to break the AVM FRITZ!Box 4040 image on purpose?

Of course I'm not trying to break anything.  But, I am not sure how to
fix this properly.  Does each platform need to specifically enable a firmware
target instead of depending on a DEPENDS statement to make it work?

Is there some other way I can provide an option for two different firmware
binaries?

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com