[LEDE-DEV] ath9k - WARN_ON origskb->len <= FCS_LEN - Driver bug?

Nick Lowe nick.lowe at gmail.com
Sat Jan 13 08:25:59 PST 2018 

Hi all,

I am seeing a WARN_ON being hit frequently with ath9k after updating
to OpenWrt SNAPSHOT r5763-89233a8. The code generating the warning
seems to point that this is a driver bug.

rx.c:
         if (ieee80211_hw_check(&local->hw, RX_INCLUDES_FCS)) {
                 if (unlikely(origskb->len <= FCS_LEN)) {
                         /* driver bug */
                         WARN_ON(1);
                         dev_kfree_skb(origskb);
                         return NULL;
                 }
                 present_fcs_len = FCS_LEN;
         }

Any thoughts? :-)


Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.585033]
------------[ cut here ]------------
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.589716] WARNING:
CPU: 0 PID: 11565 at backports-2017-11-01/net/mac80211/rx.c:629
ieee80211_rx_napi+0x1dd/0x7de [mac80211]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.601095] Modules
linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox
ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT
ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport
xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT
xt_LOG xt_CT slhc r8169 nf_reject_ipv4 nf_nat_redirect
nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat
nf_log_ipv4 nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache
nf_conntrack iptable_mangle iptable_filter ip_tables e1000e crc_ccitt
compat i2c_dev ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common
ip6table_mangle ip6table_filter ip6_tables x_tables igb i2c_algo_bit
e1000 leds_apu2 button_hotplug ptp pps_core mii
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.665926] CPU: 0 PID:
11565 Comm: kworker/u8:1 Tainted: G        W       4.9.76 #0
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.673715] Hardware
name: PC Engines APU2/APU2, BIOS 4.0.7 02/28/2017
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.680288] Workqueue:
phy0 ath_reset_work [ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.685135]
0000000000000000 ffffffff811f34ee 0000000000000000 0000000000000009
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.692664]
ffffffff8106c2bc ffff88011944f100 ffff880118e50f40 0000000000000000
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.700197]
0000000000000246 0000000000000000 ffff88011944f100 ffffffffa01ad021
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.707745] Call Trace:
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.710228]
[<ffffffff811f34ee>] ? dump_stack+0x5d/0x79
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.715590]
[<ffffffff8106c2bc>] ? __warn+0xb2/0xcb
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.720607]
[<ffffffffa01ad021>] ? ieee80211_rx_napi+0x1dd/0x7de [mac80211]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.727685]
[<ffffffff8120cfe4>] ? swiotlb_tbl_map_single+0x198/0x22e
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.734256]
[<ffffffffa0271260>] ? ath9k_cmn_rx_skb_postprocess+0x47/0x10d
[ath9k_common]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.742581]
[<ffffffffa027f2ed>] ? ath_rx_tasklet+0xc2f/0xc55 [ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.749149]
[<ffffffffa027f37a>] ? ath_stoprecv+0x67/0xbf7 [ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.755449]
[<ffffffffa027ba6b>] ? ath9k_deinit_device+0x49d/0x67d [ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.762471]
[<ffffffffa027d298>] ? ath9k_calculate_summary_state+0x46f/0x52a
[ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.770366]
[<ffffffffa027d3af>] ? ath_reset_work+0x1a/0x1cc [ath9k]
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.776845]
[<ffffffff8107c43e>] ? process_one_work+0x196/0x29f
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.782894]
[<ffffffff8107ce06>] ? worker_thread+0x28e/0x381
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.788674]
[<ffffffff8107cb78>] ? rescuer_thread+0x2d7/0x2d7
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.794536]
[<ffffffff8106f2bc>] ? do_group_exit+0x36/0x98
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.800144]
[<ffffffff81080820>] ? kthread+0xc2/0xca
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.805231]
[<ffffffff8108075e>] ? kthread_park+0x4b/0x4b
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.810753]
[<ffffffff814b6ea1>] ? ret_from_fork+0x41/0x50
Sat Jan 13 09:30:17 2018 kern.warn kernel: [49271.816387] ---[ end
trace 031f3c64238b9dd0 ]---
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.050693]
------------[ cut here ]------------
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.055414] WARNING:
CPU: 1 PID: 0 at backports-2017-11-01/net/mac80211/rx.c:629
ieee80211_rx_napi+0x1dd/0x7de [mac80211]
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.066442] Modules
linked in: ath9k ath9k_common pppoe ppp_async ath9k_hw ath pppox
ppp_generic nf_conntrack_ipv6 mac80211 iptable_nat ipt_REJECT
ipt_MASQUERADE cfg80211 xt_time xt_tcpudp xt_state xt_nat xt_multiport
xt_mark xt_mac xt_limit xt_conntrack xt_comment xt_TCPMSS xt_REDIRECT
xt_LOG xt_CT slhc r8169 nf_reject_ipv4 nf_nat_redirect
nf_nat_masquerade_ipv4 nf_conntrack_ipv4 nf_nat_ipv4 nf_nat
nf_log_ipv4 nf_defrag_ipv6 nf_defrag_ipv4 nf_conntrack_rtcache
nf_conntrack iptable_mangle iptable_filter ip_tables e1000e crc_ccitt
compat i2c_dev ip6t_REJECT nf_reject_ipv6 nf_log_ipv6 nf_log_common
ip6table_mangle ip6table_filter ip6_tables x_tables igb i2c_algo_bit
e1000 leds_apu2 button_hotplug ptp pps_core mii
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.131320] CPU: 1 PID:
0 Comm: swapper/1 Tainted: G        W       4.9.76 #0
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.138503] Hardware
name: PC Engines APU2/APU2, BIOS 4.0.7 02/28/2017
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.145056]
0000000000000000 ffffffff811f34ee 0000000000000000 0000000000000009
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.152587]
ffffffff8106c2bc ffff8801183e2100 ffff880118e50f40 0000000000000000
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.160130]
0000000000000246 0000000000000000 ffff8801183e2100 ffffffffa01ad021
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.167662] Call Trace:
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.170145]  <IRQ>
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.172095]
[<ffffffff811f34ee>] ? dump_stack+0x5d/0x79
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.177469]
[<ffffffff8106c2bc>] ? __warn+0xb2/0xcb
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.182502]
[<ffffffffa01ad021>] ? ieee80211_rx_napi+0x1dd/0x7de [mac80211]
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.189595]
[<ffffffff8120cfe4>] ? swiotlb_tbl_map_single+0x198/0x22e
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.196165]
[<ffffffffa0271260>] ? ath9k_cmn_rx_skb_postprocess+0x47/0x10d
[ath9k_common]
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.204481]
[<ffffffffa027f2ed>] ? ath_rx_tasklet+0xc2f/0xc55 [ath9k]
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.211048]
[<ffffffffa027ccd6>] ? ath9k_tasklet+0x160/0x1d9 [ath9k]
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.217519]
[<ffffffff8106f76c>] ? tasklet_action+0x9f/0xa8
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.223227]
[<ffffffff8106fa8f>] ? __do_softirq+0xb8/0x1a1
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.228831]
[<ffffffff8106fd07>] ? irq_exit+0x4f/0x5b
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.234005]
[<ffffffff8101e645>] ? do_IRQ+0xa4/0xba
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.239008]
[<ffffffff814b75d3>] ? common_interrupt+0x93/0x93
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.244866]  <EOI>
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.246823]
[<ffffffff813a1449>] ? cpuidle_enter_state+0x139/0x18e
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.253165]
[<ffffffff813a1402>] ? cpuidle_enter_state+0xf2/0x18e
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.259377]
[<ffffffff81094437>] ? cpu_startup_entry+0x15b/0x1ce
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.265504]
[<ffffffff81031ac4>] ? start_secondary+0x12b/0x12e
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.271464] ---[ end
trace 031f3c64238b9dd1 ]---
Sat Jan 13 09:30:18 2018 kern.warn kernel: [49272.361675]
------------[ cut here ]------------

Cheers,

Nick

More information about the Lede-dev mailing list