[LEDE-DEV] [PATCH 1/2] ltq-atm: rewrite tx path to use IRQs

Antti Seppälä a.seppala at gmail.com
Thu Jan 11 08:01:14 PST 2018


On 11 January 2018 at 12:54, Kevin Darbyshire-Bryant
<kevin at darbyshire-bryant.me.uk> wrote:
>
>
>> On 10 Jan 2018, at 18:47, Antti Seppälä <a.seppala at gmail.com> wrote:
>>>
>>> diff --git a/package/kernel/lantiq/ltq-atm/src/ifxmips_atm_core.h b/package/kernel/lantiq/ltq-atm/src/ifxmips_atm_core.h
>>> index 2f754c982b2a..398be7d8282a 100644
>>> --- a/package/kernel/lantiq/ltq-atm/src/ifxmips_atm_core.h
>>> +++ b/package/kernel/lantiq/ltq-atm/src/ifxmips_atm_core.h
>>> @@ -1799,7 +1840,6 @@ static int ltq_atm_probe(struct platform_device *pdev)
>>>        int ret;
>>>        int port_num;
>>>        struct port_cell_info port_cell = {0};
>>> -       int i, j;
>>
>> One small nit about the patch though - the above change seems
>> unintended and causes a compilation failure.
>
> Have to say I don’t hit that issue at all.  Build on master no problem at for Netgear DGN3500.
>
> I wonder what I’m doing wrong?
>

My bad. I used lede-17.01.4 sources in my tests instead of master
branch. In master the change does not cause any ill effects.
Sorry for the noise.

However, the patch makes an excellent stable release backport
candidate as it fixes quite a long-standing issue. So depending on
future release plans it has now been tested to work with the stable
release as well :)

Br,
-- 
Antti



More information about the Lede-dev mailing list