[LEDE-DEV] [PATCH] at91: sama5: activate fpu

[Hauke Mehrtens]

On 01/02/2018 07:26 PM, Sandeep Sheriker wrote:
> Hi Hauke,
> 
> I get below build error
> 
> make  -C
> /home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05
> sama5d2_xplained_mmc_config
> make[4]: Entering directory
> '/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05'
> 
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/kconfig/conf.o
>   SHIPPED scripts/kconfig/zconf.tab.c
>   SHIPPED scripts/kconfig/zconf.lex.c
>   SHIPPED scripts/kconfig/zconf.hash.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
>   HOSTLD  scripts/kconfig/conf
> #
> # configuration written to .config
> #
> make[4]: Leaving directory
> '/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05'
> 
> touch
> /home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05/.configured_68b329da9893e34099c7d8ad5cb9c940
> 
> rm -f
> /home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05/.built
> 
> touch
> /home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05/.built_check
> 
> make  -C
> /home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05
> CROSS_COMPILE=arm-openwrt-linux-muslgnueabi- KCFLAGS="-Os -pipe
> -mcpu=cortex-a5 -mfpu=neon-vfpv4 -fno-caller-saves -fno-plt
> -fhonour-copts -Wno-error=unused-but-set-variable
> -Wno-error=unused-result -mfloat-abi=hard
> -iremap/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05:u-boot-2016.05
> -Wformat -Werror=format-security -D_FORTIFY_SOURCE=1 -Wl,-z,now
> -Wl,-z,relro"
> make[4]: Entering directory
> '/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05'
> 
> scripts/kconfig/conf  --silentoldconfig Kconfig
>   CHK     include/config.h
>   UPD     include/config.h
>   GEN     include/autoconf.mk
>   GEN     include/autoconf.mk.dep
>   GEN     spl/include/autoconf.mk
>   CHK     include/config/uboot.release
>   UPD     include/config/uboot.release
>   CHK     include/generated/version_autogenerated.h
>   UPD     include/generated/version_autogenerated.h
>   CHK     include/generated/timestamp_autogenerated.h
>   UPD     include/generated/timestamp_autogenerated.h
>   CC      lib/asm-offsets.s
> arm-openwrt-linux-muslgnueabi-gcc: error: -mfloat-abi=soft and
> -mfloat-abi=hard may not be used together
> Kbuild:43: recipe for target 'lib/asm-offsets.s' failed
> make[5]: *** [lib/asm-offsets.s] Error 1
> Makefile:1275: recipe for target 'prepare0' failed
> make[4]: *** [prepare0] Error 2
> make[4]: Leaving directory
> '/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05'
> 
> Makefile:94: recipe for target
> '/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05/.built'
> failed
> make[3]: ***
> [/home/sandeep/microchip/arm/lede/build_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/u-boot-sama5d2_xplained_mmc/u-boot-2016.05/.built]
> Error 2
> make[3]: Leaving directory
> '/home/sandeep/microchip/arm/lede/package/boot/uboot-at91'
> package/Makefile:109: recipe for target
> 'package/boot/uboot-at91/compile' failed
> make[2]: *** [package/boot/uboot-at91/compile] Error 2
> make[2]: Leaving directory '/home/sandeep/microchip/arm/lede'
> package/Makefile:105: recipe for target
> '/home/sandeep/microchip/arm/lede/staging_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/stamp/.package_compile'
> failed
> make[1]: ***
> [/home/sandeep/microchip/arm/lede/staging_dir/target-arm_cortex-a5+neon-vfpv4_musl_eabi/stamp/.package_compile]
> Error 2
> make[1]: Leaving directory '/home/sandeep/microchip/arm/lede'
> /home/sandeep/microchip/arm/lede/include/toplevel.mk:216: recipe for
> target 'world' failed
> make: *** [world] Error 2


The patch was already merged, but I was able to reproduce this problem
and fixed in in the u-boot build file, can you please test the patch
which I sent separately. Please check if the u-boot generated by LEDE
will still work.

Hauke


> Regards,
> 
> Sandeep Sheriker M
> 
> On 12/31/2017 12:35 PM, Hauke Mehrtens wrote:
>> This activates neon and VFPv4 support for this target. The CPU support
>> these feature so also use them.
>>
>> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
>> ---
>>
>> I do not have the hardware, could some please test if this still works
>> on a at91 compatible board.
>>
>>   target/linux/at91/sama5/target.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/target/linux/at91/sama5/target.mk
>> b/target/linux/at91/sama5/target.mk
>> index 7ccf30b386..8ff6c761a9 100644
>> --- a/target/linux/at91/sama5/target.mk
>> +++ b/target/linux/at91/sama5/target.mk
>> @@ -1,6 +1,8 @@
>>   BOARDNAME:=SAMA5 Xplained boards(Cortex-A5)
>>   CPU_TYPE:=cortex-a5
>> +CPU_SUBTYPE:=neon-vfpv4
>>   +FEATURES+=fpu
>>   DEFAULT_PACKAGES += kmod-usb2
>>     define Target/Description
>