[LEDE-DEV] [PATCH netifd] proto: allow dumping protocol handlers without config_params

Olof Sivertsson osivertsson at gmail.com
Wed Jan 3 01:35:13 PST 2018


When ubus invokes proto_dump_handlers, and a struct proto_handler has
been added with a NULL config_params, a segmentation fault occurs.

Avoid this segmentation fault by checking for a NULL config_params
before further access.

Signed-off-by: Olof Sivertsson <olof.sivertsson at zenterio.com>
---
 proto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proto.c b/proto.c
index 9eb31c5..6047735 100644
--- a/proto.c
+++ b/proto.c
@@ -591,7 +591,7 @@ proto_dump_handlers(struct blob_buf *b)
 		void *v;
 
 		c = blobmsg_open_table(b, p->name);
-		if (p->config_params->validate) {
+		if (p->config_params && p->config_params->validate) {
 			int i;
 
 			v = blobmsg_open_table(b, "validate");
-- 
2.15.1




More information about the Lede-dev mailing list