[LEDE-DEV] [PATCH] uboot-envtools: Change download to git.

[Rosen Penev]

On Fri, Feb 23, 2018 at 8:09 AM, Rosen Penev <rosenp at gmail.com> wrote:
> On Fri, Feb 23, 2018 at 4:03 AM, Michael Heimpold <mhei at heimpold.de> wrote:
>> Hi,
>>
>> Am Donnerstag, 22. Februar 2018, 17:48:58 CET schrieb Rosen Penev:
>>> Currently, the build system uses an openwrt mirror which does not currently workand FTP can be unreliable under several circumstances (Ubuntu 16.04 WSL being an example). This change implicitly allows using all the mirrors to download.
>>>
>>> Changing this to git also allows using .tar.xz archives which are smaller.
>>>
>>> Size difference:
>>>
>>> 10416503 u-boot-2015.10.tar.bz2
>>> 8351456 u-boot-2015.10.tar.xz
>>>
>>> Signed-off-by: Rosen Penev <rosenp at gmail.com>
>>> ---
>>>  package/boot/uboot-envtools/Makefile | 13 +++++++------
>>>  1 file changed, 7 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/package/boot/uboot-envtools/Makefile b/package/boot/uboot-envtools/Makefile
>>> index 57a2ec5393..4d2cd342aa 100644
>>> --- a/package/boot/uboot-envtools/Makefile
>>> +++ b/package/boot/uboot-envtools/Makefile
>>> @@ -12,12 +12,13 @@ PKG_DISTNAME:=u-boot
>>>  PKG_VERSION:=2015.10
>>>  PKG_RELEASE:=1
>>>
>>> -PKG_BUILD_DIR:=$(BUILD_DIR)/u-boot-$(PKG_VERSION)
>>> -PKG_SOURCE:=$(PKG_DISTNAME)-$(PKG_VERSION).tar.bz2
>>> -PKG_SOURCE_URL:=\
>>> -     http://mirror2.openwrt.org/sources \
>>> -     ftp://ftp.denx.de/pub/u-boot
>>> -PKG_HASH:=bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955
>>> +PKG_SOURCE_PROTO:=git
>>> +PKG_SOURCE:=$(PKG_DISTNAME)-$(PKG_VERSION).tar.xz
>>> +PKG_SOURCE_SUBDIR:=$(PKG_DISTNAME)-$(PKG_VERSION)
>>> +PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_DISTNAME)-$(PKG_VERSION)
>>> +PKG_SOURCE_URL:=https://github.com/u-boot/u-boot
>>
>> I would like to NAK this. This URL seems be a repo of an arbitrary person, I don't see
>> how this is related to the original project as it is not listed anywhere on the Denx wiki or so.
>> I also found this (old) mail - don't know whether opinions changed meanswhile:
>> https://lists.denx.de/pipermail/u-boot/2009-March/049148.html
>>
> Hrm I thought this was official. I'll switch to the official uboot
> repo in a few hours.
I just did that. The hashes match. Wondering if I should go on with
this as there are people that deal with firewall problems thereby
preferring HTTPS to git.
>
>> Personally, I would prefer to fix the openwrt download mirror. Addtionally, we could
>> check, whether it's possible to use the "offical" Amazon drive
>> (https://www.amazon.com/clouddrive/share/HtTEzbceyJDyHv7anDLboEjTe0OkFbYReMxRp3CF20n?ref_=cd_ph_share_link_copy)
>> mentioned here: https://www.denx.de/wiki/U-Boot/SourceCode
> Some people (Google being a major one) are uncomfortable with using
> plain HTTP. The official website has a totally broken HTTPS setup. The
> official git repo may be cloneable through SSH so there is that.
>>
>> Regards,
>> mhei
>>
>>> +PKG_SOURCE_VERSION:=5ec0003b19cbdf06ccd6941237cbc0d1c3468e2d
>>> +PKG_MIRROR_HASH:=e207d996ebfff7335eed99789e3dcb9da071499f347fcdd86725b9d4dac5a5bb
>>>
>>>  PKG_BUILD_DEPENDS:=fstools
>>>
>>>
>>