[LEDE-DEV] [PATCH] uboot-envtools: Change download to git.

[Rosen Penev]

On Thu, Feb 22, 2018 at 11:37 PM, Alexandru Ardelean
<ardeleanalex at gmail.com> wrote:
> On Fri, Feb 23, 2018 at 3:48 AM, Rosen Penev <rosenp at gmail.com> wrote:
>> Currently, the build system uses an openwrt mirror which does not currently workand FTP can be unreliable under several circumstances (Ubuntu 16.04 WSL being an example). This change implicitly allows using all the mirrors to download.
>>
>> Changing this to git also allows using .tar.xz archives which are smaller.
>>
>> Size difference:
>>
>> 10416503 u-boot-2015.10.tar.bz2
>> 8351456 u-boot-2015.10.tar.xz
>
> The size difference is pointless here if you are about to do a git
> clone of a repository.
> The git history alone can add a transfer 2-10 times bigger than the
> tar.bz2 file [depending on the repo's git history].

That's true. The build system seems to not create shallow clones. Need
to verify but that's what it felt like (unless GitHub was being slow
while I was testing). Note that most users will not deal with git
since OpenWrt mirrors are tried first.
>
>>
>> Signed-off-by: Rosen Penev <rosenp at gmail.com>
>> ---
>>  package/boot/uboot-envtools/Makefile | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/package/boot/uboot-envtools/Makefile b/package/boot/uboot-envtools/Makefile
>> index 57a2ec5393..4d2cd342aa 100644
>> --- a/package/boot/uboot-envtools/Makefile
>> +++ b/package/boot/uboot-envtools/Makefile
>> @@ -12,12 +12,13 @@ PKG_DISTNAME:=u-boot
>>  PKG_VERSION:=2015.10
>>  PKG_RELEASE:=1
>>
>> -PKG_BUILD_DIR:=$(BUILD_DIR)/u-boot-$(PKG_VERSION)
>> -PKG_SOURCE:=$(PKG_DISTNAME)-$(PKG_VERSION).tar.bz2
>> -PKG_SOURCE_URL:=\
>> -       http://mirror2.openwrt.org/sources \
>> -       ftp://ftp.denx.de/pub/u-boot
>
> What about switching the FTP site to http://ftp.denx.de/pub/u-boot/ ?
> [At least] I prefer HTTP over git, and if FTP is problematic, HTTP
> seems reliable for this.
> HTTPS seems to exist: https://ftp.denx.de/pub/u-boot/
> But it seems to point to some owncloud/nextcloud instance, so that is
> unusable atm.
Didn't know they had an HTTP mirror. It doesn't seem linked on the
website. Note that GitHub is using HTTPS and they also recently killed
TLS 1.0 and 1.1 support.

That Nextcloud instance is probably for internal use. Should poke them about it.
>
>> -PKG_HASH:=bdc68d5f9455ad933b059c735d983f2c8b6b552dafb062e5ff1444f623021955
>> +PKG_SOURCE_PROTO:=git
>> +PKG_SOURCE:=$(PKG_DISTNAME)-$(PKG_VERSION).tar.xz
>> +PKG_SOURCE_SUBDIR:=$(PKG_DISTNAME)-$(PKG_VERSION)
>> +PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_DISTNAME)-$(PKG_VERSION)
>> +PKG_SOURCE_URL:=https://github.com/u-boot/u-boot
>> +PKG_SOURCE_VERSION:=5ec0003b19cbdf06ccd6941237cbc0d1c3468e2d
>> +PKG_MIRROR_HASH:=e207d996ebfff7335eed99789e3dcb9da071499f347fcdd86725b9d4dac5a5bb
>>
>>  PKG_BUILD_DEPENDS:=fstools
>>
>> --
>> 2.14.3
>>
>>
>> _______________________________________________
>> Lede-dev mailing list
>> Lede-dev at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/lede-dev