[LEDE-DEV] [PATCH 3/7] ag71xx: optimized iomapped register access

Felix Fietkau nbd at nbd.name
Thu Feb 22 08:58:32 PST 2018


On 2017-12-08 03:37, Rosen Penev wrote:
> Seems to remove a few instructions. Original message below:
> 
> From: Ben Menchaca <ben.menchaca at qca.qualcomm.com>
> Date: Tue, 11 Jun 2013 15:50:17 -0500
> Subject: [ag71xx] optimize iomapped register access
> 
> Add register accessors that remove the per-register range check that
> was done previously.  Additionally, we separate the write from the
> subsequent read that is designed to flush the write; this can now be
> called separately.
> 
> Signed-off-by: Ben Menchaca <ben.menchaca at qca.qualcomm.com>
> Signed-off-by: Rosen Penev <rosenp at gmail.com>
Caching direct pointers to individual register does not make much sense
to me, especially when considering performance. Addition is cheap, using
more cache lines isn't.

- Felix




More information about the Lede-dev mailing list