[LEDE-DEV] master fails to build at openvpn after today's git pull

[Magnus Kroken]

On 16.02.2018 11.33, Koen Vandeputte wrote:
> On 2018-02-16 11:28, Mauro Mozzarelli wrote:
>> I am not sure if you are already aware, master fails to build after
>> today's git pull:

Hi all

This is related to the mbed TLS update, 2.7 adds digest functions with 
return types (instead of void return), and deprecates the old void-type 
functions. See API changes and New deprecations in [1].

>> ssl_mbedtls.o: In function `tls_ctx_personalise_random':
>> ssl_mbedtls.c:(.text.tls_ctx_personalise_random+0x2a): undefined
>> reference to `mbedtls_sha256'

For OpenVPN, a patch has been submitted upstream [2]. Download the mbox 
from patchwork, and stuff it in package/network/service/openvpn/patches, 
then rebuild.

> +1 on this one:
>
> 2 minutes ago:
>
>
> make[5]: Entering directory
> '/mnt/ramdisk/test/firmware/builds/generic_imx6/build_dir/target-arm_cortex-a9+neon_musl_eabi/curl-7.58.0/lib'
>
>   CC       vtls/libcurl_la-mbedtls.lo
> vtls/mbedtls.c: In function 'Curl_mbedtls_sha256sum':
> vtls/mbedtls.c:1032:3: error: implicit declaration of function
> 'mbedtls_sha256'; did you mean 'mbedtls_sha256_ret'?
> [-Werror=implicit-function-declaration]
>    mbedtls_sha256(input, inputlen, sha256sum, 0);
>    ^~~~~~~~~~~~~~
>    mbedtls_sha256_ret

Same issue. Edit vtls/mbedtls.c, and change mbedtls_sha256 to 
mbedtls_sha256_ret. There is also a call to mbedtls_md4 somwhere in 
cURLs NTLM code (which is fixed in the same manner), but that may be 
disabled by default in OpenWrts cURL package. Upstream hasn't patched 
this yet AFAIK.

I have patches for these issues in my tree, but I won't have access to 
it for a few days, so can't submit them myself.

1: 
https://tls.mbed.org/tech-updates/releases/mbedtls-2.7.0-2.1.10-and-1.3.22-released
2: https://patchwork.openvpn.net/patch/229/

/Magnus