[LEDE-DEV] [PATCH 1/2] libubox: Don't warn about sign comparisons.

[Karl Palsson]

Rosen Penev <rosenp at gmail.com> wrote:
> -Wsign-compare was breaking my builds when i disabled MIPS16 on
> ramips (mt7621). Since this will probably not get fixed,
> disable it.

Given the fine tuned nature of all your prior commits, why are
you now all of a sudden avoiding actually fixing the bad sign
comparisons? Turning them off wholesale sounds like a terrible
idea!

Cheers,
Karl P


> 
> Signed-off-by: Rosen Penev <rosenp at gmail.com>
> ---
>  CMakeLists.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 57804cf..0449a59 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -3,7 +3,7 @@ INCLUDE(CheckLibraryExists)
>  INCLUDE(CheckFunctionExists)
>  
>  PROJECT(ubox C)
> -ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -g3
> -Wmissing-declarations) +ADD_DEFINITIONS(-Os -Wall -Werror
> --std=gnu99 -g3 -Wmissing-declarations -Wno-sign-compare)
>  
>  OPTION(BUILD_LUA "build Lua plugin" ON)
>  OPTION(BUILD_EXAMPLES "build examples" ON)
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.html
Type: application/pgp-signature
Size: 1161 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20180202/c7618131/attachment-0001.sig>