[LEDE-DEV] [PATCH] download: skip hash check without a download hash

[John Crispin]

On 30/03/18 17:34, Hauke Mehrtens wrote:
> If the package doe not contain a PKG_HASH just skip the check instead of
> making the download fail. The scripts/download.pl script will
> automatically skip the hash check in case the hash value equals skip,
> otherwise it fails.
>
> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
> ---
>   include/download.mk | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/download.mk b/include/download.mk
> index 2ba8a7bdf4..b14ce2a39a 100644
> --- a/include/download.mk
> +++ b/include/download.mk
> @@ -239,11 +239,11 @@ define Download/Defaults
>     URL_FILE:=
>     PROTO:=
>     HASH=$$(MD5SUM)
> -  MD5SUM:=x
> +  MD5SUM:=skip
>     SUBDIR:=
>     MIRROR:=1
>     MIRROR_HASH=$$(MIRROR_MD5SUM)
> -  MIRROR_MD5SUM:=x
> +  MIRROR_MD5SUM:=skip
>     VERSION:=
>     OPTS:=
>   endef

Hi,
I am against merging this patch. 
b30ba14e2a858cfebcfdbc38348ab96a6d179556 fixed an error where we had a 
copy/paste mess up of a hash causing a none valid length. we would think 
that there is hash that gets checked but it would never be validated. 
Adding your patch would introduce a similar case where a typo in the 
variable name would make us believe that a hash is present but in 
reality there it none. I'd prefer that the Makefile would have the skip 
inside it and that the buildsystem would then skip the validation.

     John