[LEDE-DEV] [PATCH 1/5] tools/zlib: move zlib build to tools

[Koen Vandeputte]

On 2018-04-20 00:15, Hauke Mehrtens wrote:
> On 04/18/2018 12:24 AM, Koen Vandeputte wrote:

> <snip>

>>> I tested the patch series because I have a linking problem with zlib
>>> and python an I wanted to see if this fixes it (it does not) but on
>>> i686 I have this error
>>>
>>>
>>> make[8]: Entering directory
>>> '/home/build/proxy/build_dir/hostpkg/glib-2.56.1/gio'
>>>    CCLD     libgio-2.0.la
>>> /usr/bin/ld: /home/build/proxy/staging_dir/host/lib/libz.a(deflate.o):
>>> relocation R_X86_64_PC32 against symbol `_length_code' can not be used
>>> when making a shared object; recompile with -fPIC
>>> /usr/bin/ld: final link failed: Bad value
>>> collect2: error: ld returned 1 exit status
>>> Makefile:2183: recipe for target 'libgio-2.0.la' failed
>>>
>>>
>> Hi Hauke,
>>
>> Probably related to the above?
>>
>> When I'm building using this patch series, I'm getting a python build
>> error.
>> Please see attached logfile.
>> Reverting the series fixes the build issue.
>>
>>
>> Do note that I'm also using my own config, which adds all feeds and uses
>> a lot more packages than default OpenWrt.
>>
>> Thanks,
>>
>> Koen
> I am not able to reproduce this problem and it looks strange because you
> have some compile problems related to OpenSSL functions.
>
> Can you provide me with a configuration which triggers this problem
> please? Are you only using these 5 patches on top of master or do you
> use also some other patches on top of master?
>
> Hauke
Hi Hauke,

I'm currently testing the V2 series.
The fpic addition fixes the build issues.


Also,

Previously I mentioned the following issue on imx6 (ubi):

- Make owrt build
- Add custom files using imagebuilder
- Flash (jtag or tftp via uboot)
- Boot 1st time (all is OK)
- Boot 2nd time (custom files are corrupt now)


After testing this a few times using JTAG on the same board (which had a 
repro rate of 100%) .. the issue seems fixed at first glance.
I wasn't able to reproduce it in the last 5 tests.



There are 2 warnings left:

WARNING: Makefile 'package/feeds/packages/python/Makefile' has a build 
dependency on 'zlib/host', which does not exist
WARNING: Makefile 'package/feeds/packages/python3/Makefile' has a build 
dependency on 'zlib/host', which does not exist


So when applying the series, an extra fix is probably needed in the 
package repo to get rid of the warnings.

Besides this, no regression seen so far ..


Thank you for the efforts!

Koen