[LEDE-DEV] [OpenWrt-Devel] [PATCH 0/4] Gemini forward-port to kernel v4.14

[Roman Yeryomin]

On 2018-04-12 00:37, Roman Yeryomin wrote:
> On 2018-04-11 00:51, Linus Walleij wrote:
>> On Mon, Apr 9, 2018 at 12:38 PM, Roman Yeryomin <roman at advem.lv> 
>> wrote:
>> 
>>> I have tested them quickly yesterday on nas4220b board. Although I've
>>> managed to boot it (had to fix rootfs image) ethernet and usb didn't 
>>> work.
>>> And I didn't check anything else.
>>> I didn't yet look at the code but before I dive there I have a 
>>> question: did
>>> you have a chance to test it yourself on any of the boards? And if 
>>> yes,
>>> which one?
>> 
>> Hm I tested mostly the rootfs and that the kernel would get to prompt.
>> But for my D-Link devices I tested mostly with kernel v4.16 because
>> I'm working close to mainline. Testing now it seems network is not
>> coming up here either :/ as it works like a charm on v4.16 it must
>> be some minor issue.
> 
> Looking at your tree...
> I don't see any (affecting) differences in ethernet driver itself.
> Probably it's something else.. MDIO?
> 

After looking into ethernet I've found several issues.
1. skew delay settings were not ported from old driver to dts for 
nas4220b board
2. kernel config in you patches (accidentally?) disabled bridge support
3. driver crashes if you try to disable unused gmac in dts because of 
access to uninitialized port(0|1) member of struct gemini_ethernet

So after fixing all above ethernet on nas4220b is working ok.

Can you confirm that after enabling bridge support back (just remove 
CONFIG_BRIDGE from gemini kernel config and rebuild) ethernet comes up 
on D-link boards? That is with default network config.


Regards,
Roman