[LEDE-DEV] [PATCH v3 1/7] Update to latest ath10k-ct driver, enable AHB.

[Ben Greear]

On 04/13/2018 03:17 PM, Matthias Schiffer wrote:
> On 04/14/2018 12:05 AM, Ben Greear wrote:
>> On 04/13/2018 02:59 PM, Matthias Schiffer wrote:
>>> On 03/21/2018 06:28 PM, greearb at candelatech.com wrote:
>>>> From: Ben Greear <greearb at candelatech.com>
>>>>
>>>> The driver updates include:
>>>>
>>>> ath10k driver backport to fix WPA 'pn' related security bugs
>>>> (4.13 based driver only currently),
>>>> a fix for off-channel TX for CT wave-1 firmware, a likely
>>>> fix for napi related crashes, and a backport of the firmware fetch
>>>> patch.
>>>>
>>>> AHB is needed for the IPQ4019 platform radios.
>>>>
>>>> Signed-off-by: Ben Greear <greearb at candelatech.com>
>>>> ---
>>>
>>> The following build log was sent to me. Admittedly, building ath10k is
>>> probably not really useful on the brcm2708 (RasPi) target, but it is
>>> currently breaking an ALL_KMODS build for this platform unless package
>>> build errors are ignored.
>>
>> Maybe that platform has no pcie support in the kernel?
>
> Correct, brcm2708 does not set CONFIG_PCI_SUPPORT (in OpenWrt .config).
> d0f3dd5b9 ("ath10k-ct: update to latest version, enable AHB.") removed the
> @PCI_SUPPORT dependency from ath10k-ct, so an ALL_KMODS build will now
> attempt to build the package.

Hmm, the AHB stuff doesn't require PCI afaik, but maybe I need some
additional #ifdefs somewhere to not try building the pci logic in
ath10k-ct for platforms that don't define PCI.

I don't have time to work on that today, but will try to look at it
early next week if no one beats me to it.

Thanks,
Ben

>
>
>>
>> Thanks,
>> Ben
>>
>>>
>>> Regards,
>>> Matthias
>>>
>>>
>>>> make[5]: Entering directory
>>>> '/scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/linux-4.9.91'
>>>>
>>>>   CC [M]
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.o
>>>>
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:
>>>> In function 'ath10k_pci_hif_start':
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:1964:2:
>>>> error: implicit declaration of function 'pcie_capability_write_word'
>>>> [-Werror=implicit-function-declaration]
>>>>   pcie_capability_write_word(ar_pci->pdev, PCI_EXP_LNKCTL,
>>>>   ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:
>>>> In function 'ath10k_pci_hif_power_up':
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:2835:2:
>>>> error: implicit declaration of function 'pcie_capability_read_word'; did
>>>> you mean 'has_capability_noaudit'? [-Werror=implicit-function-declaration]
>>>>   pcie_capability_read_word(ar_pci->pdev, PCI_EXP_LNKCTL,
>>>>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>>>>   has_capability_noaudit
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:
>>>> In function 'ath10k_pci_init_irq':
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:3246:9:
>>>> error: implicit declaration of function 'pci_enable_msi'; did you mean
>>>> 'pci_enable_sriov'? [-Werror=implicit-function-declaration]
>>>>    ret = pci_enable_msi(ar_pci->pdev);
>>>>          ^~~~~~~~~~~~~~
>>>>          pci_enable_sriov
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:
>>>> In function 'ath10k_pci_deinit_irq':
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:3285:3:
>>>> error: implicit declaration of function 'pci_disable_msi'; did you mean
>>>> 'pci_disable_sriov'? [-Werror=implicit-function-declaration]
>>>>    pci_disable_msi(ar_pci->pdev);
>>>>    ^~~~~~~~~~~~~~~
>>>>    pci_disable_sriov
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:
>>>> In function 'ath10k_pci_claim':
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:3398:8:
>>>> error: implicit declaration of function 'pci_request_region'; did you
>>>> mean 'pci_request_regions'? [-Werror=implicit-function-declaration]
>>>>   ret = pci_request_region(pdev, BAR_NUM, "ath");
>>>>         ^~~~~~~~~~~~~~~~~~
>>>>         pci_request_regions
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:3434:2:
>>>> error: implicit declaration of function 'pci_clear_master'; did you mean
>>>> 'pci_set_master'? [-Werror=implicit-function-declaration]
>>>>   pci_clear_master(pdev);
>>>>   ^~~~~~~~~~~~~~~~
>>>>   pci_set_master
>>>> /scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.c:3437:2:
>>>> error: implicit declaration of function 'pci_release_region'; did you
>>>> mean 'pci_release_regions'? [-Werror=implicit-function-declaration]
>>>>   pci_release_region(pdev, BAR_NUM);
>>>>   ^~~~~~~~~~~~~~~~~~
>>>>   pci_release_regions
>>>> cc1: some warnings being treated as errors
>>>> scripts/Makefile.build:293: recipe for target
>>>> '/scratch/hexa/build/gluon/openwrt/build_dir/target-arm_arm1176jzf-s+vfp_musl_eabi/linux-brcm2708_bcm2708/ath10k-ct-2018-03-16-30827f7d/ath10k-4.13/pci.o'
>>>> failed
>>>
>>>
>>
>>
>
>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com