[LEDE-DEV] Build error since ncurses bump

[Rosen Penev]

On Wed, Apr 4, 2018 at 4:57 AM, Koen Vandeputte
<koen.vandeputte at ncentric.com> wrote:
>
>
> On 2018-04-04 13:21, Rosen Penev wrote:
>>
>> On Wed, Apr 4, 2018 at 4:17 AM, Jo-Philipp Wich <jo at mein.io> wrote:
>>>
>>> Hi Koen,
>>>
>>> please try reverting
>>>
>>> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=4fb684a7558ea5c11580378be062f73da07f8479
>>> and see if it fixes the issue.
>
> Reverting this one indeed fixes the issue.
> Thanks again for the very accurate suggestion!
>
>
>>> The change was likely not tested on systems with a gcc 5 host compiler.
>>
>> Not at all.
>
> I can interpret this in 2 ways, which is the correct one?
>
> - "You are right, It was indeed not tested"
> - "That's not true! it was tested".
>
>
> In case it's option 1:
>
> Isn't it a bit dangerous to alter specific gcc version stuff without
> actually _testing_ it on the mentioned compiler? ;-)
> I'm running Ubuntu 16.04 LTS, like very probably a lot of people do. (which
> comes with gcc 5.4.0 by default)
Hmm? I believe jow is talking about the toolchain. It was switched to
default to GCC7 recently.

I use Arch Linux
>
>
> Thanks,
>
> Koen