[LEDE-DEV] [PATCH uclient] uclient-http: fix Host: header for literal IPv6 addresses

[Jo-Philipp Wich]

Hi Matthias,

> For literal IPv6 addresses, the host header must have the form
> 
> Host: [...]
> 
> including the square brackets, as it may also contain a port. Some 
> webservers ignore the missing brackets, while others will return
> error 400.
> 
> IPv6 addresses are determined by searching for ':' characters in the
> host, as neither IPv4 addresses nor DNS names can contain colons. An
> alternative would be to add a flag to the uclient_url struct; but as
> this struct is exposed in public headers, such a change could be
> considered an ABI change, making a backport difficult.
> 
> Signed-off-by: Matthias Schiffer <mschiffer at universe-factory.net> 

I would've solved it the same way so ...

Acked-by: Jo-Philipp Wich <jo at mein.io>

~ Jo