[LEDE-DEV] [PATCH 9/9] ar71xx: add support for Comfast E214N V2 Outdoor CPE

Zoltan HERPAI wigyori at uid0.hu
Mon Oct 23 23:49:40 PDT 2017


Piotr Dymacz wrote:
> Hello Zoltan,
> On 22.10.2017 22:21, Zoltan HERPAI wrote:
>> Based on Robert Budde's patch, with additional reworks.
>> https://github.com/openwrt/openwrt/pull/390
>> Signed-off-by: Zoltan HERPAI <wigyori at uid0.hu>
>> ---
>> [snip]
> We have some COMFAST devices already supported under ar71xx target in 
> LEDE and as they are very similar, support for all of them (IIRC) is 
> kept in single mach file [1]. This limits code duplication, e.g. for 
> their external watchdog, network initialization, etc.
> Also, after a brief review, I found some issues here:
> - LED names don't follow general naming convention (color is missing)
> - support for reset button is missing
> - COMFAST keeps ART copy in last 64 KB mtd partition, thus we have a 
> "art-backup" partition defined [2], not "nvram" as in the patch
> Personally, I would prefer to include support for this model in the 
> same way as we did for rest from this vendor. How would you like to 
> proceed with this one then?
For the record, we've started to work on this offline with Bill and 
Piotr to add support into the common mach file.


More information about the Lede-dev mailing list