[LEDE-DEV] [OpenWrt-Devel] [PATCH 8/9] ramips: add Devolo WiFi Repeater (mt2681)

Mathias Kresin dev at kresin.me
Sun Oct 22 23:14:50 PDT 2017

22.10.2017 22:21, Zoltan HERPAI:
> This is pretty much the same as the ALL0256N-8M but with different LED settings.
> Based on Matt Jenkins' patch, with additional reworks.
> https://github.com/openwrt/openwrt/pull/491
> Signed-off-by: Zoltan HERPAI <wigyori at uid0.hu>

Hey Zoltan,

I'm not sure how proceed with the patch. It has bunch of issues and if 
someone else would send this patch I wouldn't merge it as it is.

Some of the issues are:

- missing hardware description in the commit message
- missing initial install instructions in the commit message
- bad board naming (the name looks like a mediatek reference board)
- wrong use of wifi led
- outdated syntax in the dts

Since you most likely do not have this board, I'm not sure if it does 
make any sense to do the full review => request changes cycle.

Any suggestions how to proceed with this one?


More information about the Lede-dev mailing list