[LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

Kevin Darbyshire-Bryant ldir at darbyshire-bryant.me.uk
Tue Oct 17 14:16:50 PDT 2017

On 17/10/17 21:52, rosenp at gmail.com wrote:
> I'll take your word for it since I have no hardware to test on.

I'd say it has a huge impact on performance irrespective of hardware 
'cos the patch as supplied doesn't actually compile ;-)

   CC      drivers/net/ethernet/atheros/ag71xx/ag71xx_main.o
drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c: In function 
drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c:1163:2: error: too 
many arguments to function 'napi_complete'
   napi_complete(napi, rx_done);
In file included from ./include/linux/etherdevice.h:26:0,
                  from drivers/net/ethernet/atheros/ag71xx/ag71xx.h:27,
                  from drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c:14:
./include/linux/netdevice.h:465:20: note: declared here
  static inline void napi_complete(struct napi_struct *n)
scripts/Makefile.build:293: recipe for target 
'drivers/net/ethernet/atheros/ag71xx/ag71xx_main.o' failed
make[10]: *** [drivers/net/ethernet/atheros/ag71xx/ag71xx_main.o] Error 1


More information about the Lede-dev mailing list